Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Expression shortcut is no longer working in 4.2 and also breaks the script editor #83795

Closed
MewPurPur opened this issue Oct 22, 2023 · 13 comments

Comments

@MewPurPur
Copy link
Contributor

MewPurPur commented Oct 22, 2023

Godot version

Godot v4.2.beta2 - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) () - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)

System information

Godot v4.2.beta2 - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) () - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)

Issue description

Evaluate Expression in the script editor is no longer working in latest 4.2. It's still working from the context menu, but not when I do Ctrl+Shift+E.

Not only this, but it breaks the script editor and you can only navigate through it after that, like it's read-only.

Steps to reproduce

Type PI/2 in the script editor and do Ctrl+Shift+E.

Expectation: 1.57

Reality: "(2) Caller thread can't call this function in this node (/root). Use call_deferred() or call_thread_group() instead."

Minimal reproduction project

N/A

@MewPurPur MewPurPur changed the title Evaluate Expression shortcut is no longer working in latest 4.2 Evaluate Expression shortcut is no longer working in 4.2 and also breaks the script editor Oct 22, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Oct 29, 2023

Can't reproduce in beta3.

@MewPurPur
Copy link
Contributor Author

I can still reproduce this in beta3.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 29, 2023

1dgPyi1S7Q.mp4

Then maybe it requires some extra steps?

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Oct 29, 2023

What you're doing is exactly the same as what I did. I can reproduce it consistently in multiple of my projects. Maybe my machine has something to do with this?

@akien-mga akien-mga added this to the 4.2 milestone Oct 30, 2023
@akien-mga
Copy link
Member

I also can't reproduce on Linux (Mageia 9, KDE on X11, using default editor settings).

Could you test with default editor settings / in self-contained mode, to see if that's caused by an editor setting?

@github-project-automation github-project-automation bot moved this to Pending Decision in 4.x Release Blockers Oct 30, 2023
@akien-mga akien-mga modified the milestones: 4.2, 4.3 Nov 9, 2023
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Jan 2, 2024

I didn't do that, but I think I dug up what might have been the cause: https://askubuntu.com/questions/1083913/what-does-ctrl-shift-e-do-while-typing-text

I don't get the errors I mentioned in my original post, and I don't get easily locked out, and the underlined "e" now appears as described in the linked post. The functionality doesn't work as described, but it's probably not on Godot's end.

When in this state, I can still find ways to lock myself out of the code editor, although again, not as easily as before. A lot of the same issues also happen when I press Ctrl+Shift+U.

Example of a softlock:

  • Ctrl+Shift+U for entering a unicode.
  • Right click somewhere.

@KoBeWi
Copy link
Member

KoBeWi commented Jan 2, 2024

It doesn't look like Godot issue and thus could be closed. Just rebind the shortcut I guess.
It could've been resolved earlier if you'd test some earlier version 🙃(to rule out a regression)

@MewPurPur
Copy link
Contributor Author

I don't think so, the softlock still exists, but the source is not what I thought it was.

@KoBeWi
Copy link
Member

KoBeWi commented Jan 2, 2024

Right, but is it something we can fix, or it's another one of these magic Linux shortcuts that break everything (like the Alt+drag)?

@MewPurPur
Copy link
Contributor Author

Seems like my initial report was two separate bugs: Godot not behaving properly for Ctrl+Shift+E (fixed in the meantime it looks like), and the editor breaking when you make certain actions while there's a special character (still not fixed).

The unfixed one I don't think can slide, I don't even think Ctrl+Shift+U is Linux-only.

@MewPurPur
Copy link
Contributor Author

I'll test if this is now fixed.

@KoBeWi KoBeWi removed this from the 4.3 milestone Jul 25, 2024
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Sep 15, 2024

Ctrl+Shift+E now behaves much better, but this issue still exists:

  • Press Ctrl+Shift+E (or Ctrl+Shift+U for entering a unicode)
  • Right-click somewhere in the code editor.
  • Your inputs are now swallowed and you can't write code.

I'm closing this and opening a separate issue for that.

@MewPurPur
Copy link
Contributor Author

#97035

@akien-mga akien-mga added this to the 4.3 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants