Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows cannot be disabled in the material in the Compatibility renderer #84386

Closed
Tracked by #66458
nauta-turbidus opened this issue Nov 2, 2023 · 1 comment · Fixed by #84416
Closed
Tracked by #66458

Shadows cannot be disabled in the material in the Compatibility renderer #84386

nauta-turbidus opened this issue Nov 2, 2023 · 1 comment · Fixed by #84416

Comments

@nauta-turbidus
Copy link

nauta-turbidus commented Nov 2, 2023

Godot version

Godot v4.2.beta (b733901)

System information

Godot v4.2.beta (b733901) - Solus 4.4 - X11 - GLES3 (Compatibility) - Mesa Intel(R) HD Graphics 3000 (SNB GT2) () - Intel(R) Core(TM) i5-2500K CPU @ 3.30GHz (4 Threads)

Issue description

The shadows_disabled render mode doesn't work at all with the Compatibility renderer, it simply isn't implemented.

Steps to reproduce

-add any two MeshInstances to a 3D scene
-add a light so that shadow falls on one of the meshes
-add a new shader material to the shadowed mesh and create a shader
-add render_mode shadows_disabled; to the shader
-shadows are still visible

Minimal reproduction project

N/A

@YuriSizov
Copy link
Contributor

YuriSizov commented Nov 3, 2023

Probably an oversight from #77496 ? cc @clayjohn

Edit: SHADOWS_DISABLED is defined in the material storage, but not used in the scene shader as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants