Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpinSliders can't be dragged on some nodes #88294

Closed
passivestar opened this issue Feb 13, 2024 · 2 comments · Fixed by #88182
Closed

SpinSliders can't be dragged on some nodes #88294

passivestar opened this issue Feb 13, 2024 · 2 comments · Fixed by #88182

Comments

@passivestar
Copy link
Contributor

Tested versions

Reproducible in master: v4.3.dev.custom_build [e92d55b]
Not reproducible in v4.2.1.stable.official [b09f793]

System information

macOS 14.2.1 - Vulkan (Forward+) - integrated Apple M1 Max - Apple M1 Max (10 Threads)

Issue description

For some reason sliders are undraggable on some nodes because they immediately stop being dragged after one frame:

43.mp4

This doesn't happen in 4.2:

42.mp4

Steps to reproduce

Create a DirectionalLight3D node and drag any of its transform properties

What's interesting is that it doesn't happen for any node, for example there's no issue when trying to do this with MeshInstance3D, but there's an issue with DirectionalLight3D. And I saw that in some other nodes too

Minimal reproduction project (MRP)

N/A

@AThousandShips
Copy link
Member

AThousandShips commented Feb 13, 2024

Probably related:

Can you try with [41564aa]?

And with:

Probably indeed given this line:

godot/scene/3d/light_3d.cpp

Lines 283 to 285 in e92d55b

case NOTIFICATION_TRANSFORM_CHANGED: {
update_configuration_warnings();
} break;

@passivestar
Copy link
Contributor Author

Can you try with [https://github.com/godotengine/godot/commit/41564aaf7708b0bf594f745dd2448a54dd687cc5]?

This works

And with: #88182

This works too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants