Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystem Does Not Behave Properly During Rescanning #89218

Open
nongvantinh opened this issue Mar 6, 2024 · 1 comment
Open

FileSystem Does Not Behave Properly During Rescanning #89218

nongvantinh opened this issue Mar 6, 2024 · 1 comment

Comments

@nongvantinh
Copy link
Contributor

nongvantinh commented Mar 6, 2024

Tested versions

Current master at commit: 9b94c80

System information

Windows 11

Issue description

I'm in the process of implementing proposal 5633, and this error is occurring. It seems that during the rescan process, threading is not working correctly. This issue only occurs when there are more than two files being renamed.

Here is the error message, but it is not the root cause. There seems to be an issue with threading; that's all I know so far:

editor\editor_file_system.cpp:1710 - Condition "packed_scene.is_null()" is true. Returning: HashSet<StringName>()

Steps to reproduce

FileSystem.Does.Not.Behave.Properly.During.Rescanning.mp4

Look at the modified time of these files; the modification dates of the last two selected files have reverted back to several days ago.

image

Minimal reproduction project (MRP)

Please test with this PR: #89063

@nongvantinh
Copy link
Contributor Author

nongvantinh commented Mar 7, 2024

It seems like a problem with caching instead. When I close the editor and reopen the project, these cached files are corrected to their correct names.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants