Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals from signal bus are marked as "not used in the class" #93202

Closed
inhalt120g opened this issue Jun 15, 2024 · 1 comment · Fixed by #76020
Closed

Signals from signal bus are marked as "not used in the class" #93202

inhalt120g opened this issue Jun 15, 2024 · 1 comment · Fixed by #76020

Comments

@inhalt120g
Copy link

inhalt120g commented Jun 15, 2024

Tested versions

v4.3.beta1.official [a4f2ea9]
(not happening in 4.2.2)

System information

Godot v4.3.beta1 - macOS 14.5.0 - Vulkan (Forward+) - integrated Apple M1 - Apple M1 (8 Threads)

Issue description

Signal bus is a pattern that Godot practically makes obligatory. It is often (from what I saw of other people's code) implemented as one of autoloads, usually as a script containing only and dedicated exclusively to signals.

Since 4.3, every signal in such a script is producing a warning.
image
This can get quite annoying when there's more than a few of these.

I understand that I can just add an "ignore warning" for each signal and I understand that the way this is detected is actually more logical than what we had before (since indeed what the warning is reporting is technically true), but I think it makes no sense to require adding an "ignore warning" every time I create a new signal in this type of autoload.

Steps to reproduce

Make a signal bus, launch a project, read the warnings.

Minimal reproduction project (MRP)

Any.

@dalexeev
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants