[C#] Custom VisualShaderNodeCustom scripts are not recognized as shader nodes in Godot 4.2+

[jonatanrojderd]

Tested versions

Reproducible in:

• 4.2.1.stable.mono
• 4.2.2.stable.mono

System information

Godot v4.2.1.stable.mono - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 2080 Ti (NVIDIA; 31.0.15.4617) - AMD Ryzen Threadripper 2970WX 24-Core Processor (48 Threads)

Issue description

When trying to create a script inheriting from VisualShaderNodeCustom the engine / visual shader doesn't recognize the custom shader node created in C#. Custom GDScript shader nodes works.

I saw that there was a closed issue with a similar error, but it seems like the solution was for GDScript only.
#67268
#67407
#69738

The C# file used in the repro project will use this as the "template", since the built-in one is broken:
#94693

Steps to reproduce

• Create a new or use existing project
• Create a node inheriting from VisualShaderNodeCustom and compile
• Open a VisualShader in the editor
• Try and add the new node

Minimal reproduction project (MRP)

ZIP:
VisualShaderNodeTest.zip

Link:
https://github.com/jonatanrojderd/VisualShaderNodeTest

[AThousandShips]

Does it work with [GlobalClass]?

As per the documentation for VisualShaderNodeCustom it needs class_name:

In order for the node to be registered as an editor addon, you must use the @tool annotation and provide a class_name for your custom script.

Which I think is equivalent to [GlobalClass] in C# no?

[jonatanrojderd]

I’ve tried using both with no success, I was unsure about the GlobalClass attribute so I removed it while testing some more and then submitted this

[AThousandShips]

CC @raulsntos

[raulsntos]

I'm unable to reproduce on v4.2.2.stable.mono.official [15073af] with the [GlobalClass] attribute. Using the attribute makes the type appear in the Create Shader Node dialog:

As AThousandShips said, the [GlobalClass] attribute is the C# equivalent to GDScript's class_name. Make sure to build the C# project after adding the attribute, and check that there are no compilation errors.

[jonatanrojderd]

Thanks, I tried using both the Tool and GlobalClass attributes before. Tho it didn't work to just recompile the project, I had to restart Godot entierly to get it to pop up. The weird thing is that I've used both attributes before and it didn't show up after restart etc.

Tried it with my actual project and can confirm that I need to build (or even rebuild in Rider) and then restart Godot. So there might be some sort of sync error happening? Or hopefully it's just my setup and nothing "major".

[jonatanrojderd]

Also, I guess I should update my PR (#94693) to include the GlobalClass attribute, if it's needed by the engine to be able to recognize the custom node?

[AThousandShips]

I had to restart Godot entierly to get it to pop up.

That's a known bug

This should be clarified even further on the documentation, with a C# example along with the GDScript one, but otherwise this has been resolved

The demo should be updated as well

[jonatanrojderd]

Alright, sound good!