Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPRequest.set_tls_options to TLSOptions.client_unsafe() isn't working anymore in Godot 4.3 #95988

Closed
D2klaas opened this issue Aug 23, 2024 · 1 comment

Comments

@D2klaas
Copy link

D2klaas commented Aug 23, 2024

Tested versions

reproducible in Godot 4.3
not reproducible in Godot 4.2.2

System information

Window 10

Issue description

HTTPRequest.set_tls_options( TLSOptions.client_unsafe() ) should disable TLS handshake validation.
But when calling a Server with a self signed certificate the error "E 0:00:02:0815 _do_handshake: TLS handshake error: -9984
<C++-Quelle> modules/mbedtls/stream_peer_mbedtls.cpp:89 @ _do_handshake()" appears.

That wasn't so ingodot 4.2.2

Steps to reproduce

extends HTTPRequest

func _ready() -> void:
	var opts =  TLSOptions.client_unsafe()
	print("Unsafe:", opts.is_unsafe_client())
	set_tls_options( opts )
	request("https://URL_TO_UNSAFE_SERVER", [], HTTPClient.METHOD_POST, "")

Minimal reproduction project (MRP)

issue.zip

@Faless
Copy link
Collaborator

Faless commented Sep 3, 2024

Fixed in #96172 , see #96170 for details.

@Faless Faless closed this as completed Sep 3, 2024
@akien-mga akien-mga added this to the 4.4 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants