Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-threaded Web exports are broken #97073

Closed
adamscott opened this issue Sep 16, 2024 · 1 comment · Fixed by #96959
Closed

Single-threaded Web exports are broken #97073

adamscott opened this issue Sep 16, 2024 · 1 comment · Fixed by #96959

Comments

@adamscott
Copy link
Member

adamscott commented Sep 16, 2024

Tested versions

System information

Godot v4.4.dev (2c136e6) - macOS 14.6.1 - Metal (Forward+) - integrated Apple M3 Max (Apple9) - Apple M3 Max (16 Threads)

Issue description

This errors shows up on non-threaded web exports.

ERROR: Can't add a group task because the WorkerThreadPool is either not initialized yet or already terminated. [tmp_js_export.js:474:18](http://localhost:8060/tmp_js_export.js)
   at: _add_group_task (core/object/worker_thread_pool.cpp:546) [tmp_js_export.js:474:18](http://localhost:8060/tmp_js_export.js)
Capture d’écran, le 2024-09-16 à 08 46 14

Steps to reproduce

  1. Export a web game without thread support
  2. See that there's a flood of the described error

Minimal reproduction project (MRP)

n/a

@adamscott
Copy link
Member Author

@RandomShaper From a quick test, it seems to be related to this new check:

ERR_FAIL_COND_V_MSG(threads.is_empty(), INVALID_TASK_ID, "Can't add a group task because the WorkerThreadPool is either not initialized yet or already terminated.");

Because before the added check, single-threaded builds would call WorkerThreadPool::_add_group_task() without any (apparent) issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment