Multiple ScrollContainer nodes under a TabContainer show warning messages

[Odiobill]

Tested versions

• Reproducible in 4.3.stable

System information

CachyOS Linux (Arch based), kernel 6.11.0-2-cachyos (64-bit)

Issue description

Adding multiple ScrollContainer nodes under a TabContainer shows yellow triangles with the warning message:

• ScrollContainer is intended to work with a single child control.

The warning will appear for every ScrollContainer after the first one.

Steps to reproduce

• Create a new UI scene
• Add a TabContainer node
• Add a ScrollContainer node under the TabContainer
• (expected) the ScrollContainer will show the warning because it doesn't have any child
• Add any control node under the ScrollContainer
• (expected) the warning will disappear
• Duplicate the ScrollContainer, or add a new one with a single control child, to create another tab
• Newly added (or duplicated) ScrollContainer nodes will keep showing the warning message

Minimal reproduction project (MRP)

N/A

[AThousandShips]

This is caused by an oversight in the checks for the scroll container check:

godot/scene/gui/scroll_container.cpp

Lines 535 to 557 in 0a4aedb

	PackedStringArray ScrollContainer::get_configuration_warnings() const {
	PackedStringArray warnings = Container::get_configuration_warnings();
	int found = 0;
	for (int i = 0; i < get_child_count(); i++) {
	Control *c = as_sortable_control(get_child(i));
	if (!c) {
	continue;
	}
	if (c == h_scroll || c == v_scroll) {
	continue;
	}
	found++;
	}
	if (found != 1) {
	warnings.push_back(RTR("ScrollContainer is intended to work with a single child control.\nUse a container as child (VBox, HBox, etc.), or a Control and set the custom minimum size manually."));
	}
	return warnings;
	}

This should probably use: as_sortable_control(get_child(i), SortableVisbilityMode::VISIBLE);

CC @KoBeWi

[daveTheOldCoder]

The warning messages were present in Godot 4.4-dev3, but are no longer present in 4.4-dev4.