Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinbox display does not round properly when using decimal custom arrow steps #97561

Closed
ManOfDuck opened this issue Sep 28, 2024 · 3 comments · Fixed by #97573
Closed

Spinbox display does not round properly when using decimal custom arrow steps #97561

ManOfDuck opened this issue Sep 28, 2024 · 3 comments · Fixed by #97573
Milestone

Comments

@ManOfDuck
Copy link

Tested versions

  • Reproducible in: v4.2.2 stable, v4.3 stable

System information

Godot v4.3.stable - macOS 15.0.0 - GLES3 (Compatibility) - AMD Radeon Pro 5300M OpenGL Engine - Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 Threads)

Issue description

Using a 0 step value and a decimal custom arrow step on a spinbox causes the displayed value in the spinbox to round incorrectly at some numbers, despite the internal value being rounded. I'm fairly sure this was working previously on both 4.2.2 and 4.3, so its possible its due to me upgrading to the newest macOS. Also reproduced with arrow steps like 0.2, 0.9, and 1.1, and in brand-new project.

Screen.Recording.2024-09-27.at.6.19.24.PM.mov

Steps to reproduce

Create a new spinbox node, set its step value to 0 and its custom arrow step to a decimal value besides 0.5. Interacting with the arrows results in the issue

Minimal reproduction project (MRP)

N/A

@ManOfDuck
Copy link
Author

ManOfDuck commented Sep 28, 2024

There's seems to be some disagreement between what's displayed in the remote tab and what's printed in other parts of my project, but I haven't picked up on anything consistent. I wonder if it's possible that there's some general float rounding issues around the engine in macOS 15.0?

@shahriarlabib000
Copy link
Contributor

shahriarlabib000 commented Sep 28, 2024

Reproducible on Android . Might have found the problem working on a fix

@shahriarlabib000
Copy link
Contributor

Reproducible in 3.6.stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants