Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues on mac #97980

Closed
chancemcdonaldsims opened this issue Oct 8, 2024 · 8 comments
Closed

Rendering issues on mac #97980

chancemcdonaldsims opened this issue Oct 8, 2024 · 8 comments

Comments

@chancemcdonaldsims
Copy link

Tested versions

I only testing with godot 4.3

System information

mac os 15.0.1 Godot 4.3

Issue description

Some materials cause graphics issue that are hard to work around.
image

Steps to reproduce

the issues have happed when things involve transparency. In the photo included it is created with CSG volumes. When working with one the graphics issues happen. The artifacts are high frequency and hard to work with.

Minimal reproduction project (MRP)

issue.zip
Rotating around scene shows graphic issues. Could be around z fighting issues.

@AThousandShips
Copy link
Member

Please provide more system information, you can copy this information to your clipboard by using Help > Copy System Info at the top of the editor window.

@bruvzg
Copy link
Member

bruvzg commented Oct 8, 2024

Reproducible on both macOS and Windows. There's some visible Z-fighting between selected CGSBox and resulting shape.

The interference pattern is different (squares on M1 Mac, stripes on NVIDIA/Windows), but this is the same effect.
Screenshot 2024-10-08 200549

@chancemcdonaldsims
Copy link
Author

Reproducible on both macOS and Windows. There's some visible Z-fighting between selected CGSBox and resulting shape.

The interference pattern is different (squares on M1 Mac, stripes on NVIDIA/Windows), but this is the same effect. Screenshot 2024-10-08 200549

Please provide more system information, you can copy this information to your clipboard by using Help > Copy System Info at the top of the editor window.

Godot v4.3.stable - macOS 15.0.0 - Vulkan (Forward+) - integrated Apple M1 Max - Apple M1 Max (10 Threads)

@chancemcdonaldsims
Copy link
Author

Reproducible on both macOS and Windows. There's some visible Z-fighting between selected CGSBox and resulting shape.

The interference pattern is different (squares on M1 Mac, stripes on NVIDIA/Windows), but this is the same effect. Screenshot 2024-10-08 200549

@bruvzg So is it a bug or not? I don't know if this is avoidable but I don't recall any issues with CSG in past. I also had similar rendering issues with skinned meshes in Godot 4.3 when the meshes had transparency enabled.

@clayjohn clayjohn added discussion and removed bug labels Oct 8, 2024
@chancemcdonaldsims
Copy link
Author

Screen.Recording.2024-10-08.at.3.23.57.PM.mov

Just to provide more context this video provide more information on experience. It is actually sickening to watch this effect for me. I have a large monitor 43" and it produces a flashing effect that may effect people with disabilities more (like epilepsy). I actually having to switch to Blender to prototype because I can't endure effect anymore.

Screen.Recording.2024-10-08.at.3.29.44.PM.mov

This is an imported model from mixamo. It has a similar effect so I think this is more than z fighting.

@godotengine godotengine deleted a comment from chvanin Oct 9, 2024
@bruvzg
Copy link
Member

bruvzg commented Oct 10, 2024

So is it a bug or not?

Yes, I would consider it a bug (just not a macOS specific).

This is an imported model from mixamo. It has a similar effect so I think this is more than z fighting.

This might be something completely different, in case of CGSBox it's likely cause by selection and shape having face in the same plane (both are generated from the same data, so this is expected, we probably should add some offset to the selection), there's no obvious reason for the model case (and seems like no transparency involved), not sure what's going on.

@kebabskal
Copy link

https://github.com/user-attachments/assets/e238da45-13cc-4573-9b9d-2d0f1227e41e
I'm also affected by this. Makes it very uncomfortable to work with 3D.
I don't remember having this problem, at least not to this extent, on earlier versions.

Side note:
In this particular example I'm using a CSGBox with collision turned on, where the collision shape more or less by definition is going to have coplanar faces. Do we really even need to draw the collision mesh? Even when working correctly I find the collision mesh be distracting and covering up my object. Turning off "Draw Gizmos" also hides the resize handles so that's not an option.

System information
Godot v4.4.dev5 - macOS 15.1.1 - Multi-window, 1 monitor - Metal (Forward+) - integrated Apple M4 (Apple9) - Apple M4 (10 threads)

@Calinou
Copy link
Member

Calinou commented Dec 16, 2024

Thanks for the report! Consolidating in #99184.

This should be fixed by #100211.

This is an imported model from mixamo. It has a similar effect so I think this is more than z fighting.

These artifacts are caused by glow having NaNs (similar to #70809). Without having access to the project though, it's impossible to know why these NaNs are being generated though. You can disable glow in the preview environment as a workaround.

@chancemcdonaldsims If you still have access to that project, please upload it here so the issue can be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants