Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Brace Complete editor setting is incorrectly described #98260

Closed
lostminds opened this issue Oct 17, 2024 · 1 comment · Fixed by #97656
Closed

Auto Brace Complete editor setting is incorrectly described #98260

lostminds opened this issue Oct 17, 2024 · 1 comment · Fixed by #97656

Comments

@lostminds
Copy link

Tested versions

4.3.stable

System information

macOS 15.0.1

Issue description

The editor setting text_editor/completion/auto_brace_complete description doesn't really explain what it currently does. I think it's working as intended, so the description should be changed to make it easier to find user that want to change this behavior:

Current implementation:
Screenshot 2024-10-17 at 11 12 54

  • This doesn't mention that it also inserts a closing single or double quote, not just parentheses/braces
  • It says it completes braces during code completion, but it just inserts additional characters directly when typing and it seems to be completely unrelated to the more advanced code completion functionality.

A more accurate description could be something like
"If true automatically inserts a closing brace, parentheses or quote after the cursor when typing one of these characters"

Steps to reproduce

Take a look in the editor settings and compare this to how the setting works.

Minimal reproduction project (MRP)

Just editor needed

@kitbdev
Copy link
Contributor

kitbdev commented Oct 17, 2024

Feel free to review the description there.

@AThousandShips AThousandShips added this to the 4.4 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants