Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android editor crash upon loading big project #98330

Closed
Saul2022 opened this issue Oct 19, 2024 · 10 comments
Closed

Android editor crash upon loading big project #98330

Saul2022 opened this issue Oct 19, 2024 · 10 comments

Comments

@Saul2022
Copy link

Saul2022 commented Oct 19, 2024

Tested versions

Reproducible in 4.4 dev. #42224 ( perhanps in 4.3 too since upon restarting game after playing it, it crashes)

System information

Sansung s23+ Vulkan Mobile

Issue description

It seems that upon when i open a big project in godot master branch after the last dev version( dev3) it seems that while it loads the project at the last instance when like it loads editor layout it crashes in big projects like tps demo( in which before at 4.3 it didn't happen at all)( might post a video later, running out of battery)

Edit: video

crash.MOV

And weirdly enough it also kind of happens in 4.4 dev 3 , but not on the same way as there it can be reproduced by first playing the game and after that minizing the window and then clicking on the restart game button it crashes too.

Edit: other one that showcashes this crash on dev 3

Screen_Recording_20241020_090815_One.UI.Home.mp4

Steps to reproduce

• Open the roject linked below at mrp section

• Load it ( which at the end crashes on android)

• If you can't reproduce , then maybr try going by playing game and after that restart , which might trigger another crash

Minimal reproduction project (MRP)

Not small., but it reproducee it.

https://drive.google.com/file/d/1wg1PLTlc6pZs-HzFzQEGAkN3Oo7sqAfB/view?usp=sharing

@Saul2022
Copy link
Author

Saul2022 commented Oct 22, 2024

To complement it a bit more memory usage in 4.4 dev is 91%( while i had a ram monitor app opened( doesnt affect that much tho) while in 4.3 it 79/78 . So then it might be because in 4.4 dev ram increased way too much? If so what would be the solution to this aside from sure profile?

Edit: though it seems that when playing game it has 118mb on the numbers below the vSync check, so would it be vram? I have 8gb ram and those it shared as this device has no dedicated vram or i think so.

@Saul2022
Copy link
Author

Saul2022 commented Oct 29, 2024

Also it seem’s that testing on a laptop they gifted me for school use only( i had to test it there to confirm) it seems to work just fine on pc in a low end pc( which seems runs game worse than my old computer that got broken, which makes me realise it the android editor fault where in there it crashes. Maybe. It caused by some stuff that got adjusted in recent betas than later got worse because in 4.3 atleast i can open the project 😅.

@Saul2022
Copy link
Author

Saul2022 commented Nov 7, 2024

@m4gr3d I am sorry for having to ping you about this, but this is still reproducible in the latest build and makes using 4.4 unussable for me.

Late edit on 12/11 This is still reproducible on dev 4 , but now gives this error before quitting

 drivers/vulkan/rendering_device_driver_vulkan.cpp:2614 - Condition "err != VK_SUCCESS && err != VK_SUBOPTIMAL_KHR" is true. Returning: FAILED
--- De ```

@Saul2022
Copy link
Author

Saul2022 commented Dec 7, 2024

Still reproducible in dev 6 in both tps demo, my project upon loading game and when trying with gdquest character demo( which is small compared to the other 2) core/extension/gdextension_library_loader.cpp:350 - GDExtension only comp)

@llama-nl
Copy link

llama-nl commented Jan 8, 2025

I tested the demo project on Galaxy m14 4g. though, I was getting 2 fps but didn't face any crash. I managed to get upto 20 fps after some optimization. And run the project everything working fine. Just the project was restarting after exit the game. Probably it could be a GPU releted problem.

@Saul2022
Copy link
Author

Saul2022 commented Jan 8, 2025

. And run the project everything working fine.
.

You tried the custom tps i linked thst was used as a benchmark for the forge pr ?

Just the project was restarting after exit the game

Yea i faced that a ton of times in 4.3, but idk if it relarted to this.

Probably it could be a GPU related problem.

My system is all updated to the latest version, and the phone is still relatively new( just 1 number behind s24 which is the latest sansung model to date) . Moreover it never happened in 4.3.

Either way thank you for testing out., i am glad someone noticed it atleast.

@akien-mga akien-mga added this to the 4.4 milestone Jan 8, 2025
@akien-mga
Copy link
Member

Can you confirm that this only happens in 4.4 dev 3 and later, but not in 4.4 dev 2, dev 1, or 4.3 stable?

@Saul2022
Copy link
Author

Saul2022 commented Jan 8, 2025

Can you confirm that this only happens in 4.4 dev 3 and later, but not in 4.4 dev 2, dev 1, or 4.3 stable?

It doesn´t happen on 4.3 stable for the tps demo, for dev 1 and 2, i will try it when i have time but i think i remembered trying it out when hilderin made perf improvements to project load times before( here is the pr #95678 ). As for my personal project it does work, but engine restarts itself after pressing the play button similar to what Greendev faced in his issue #98112 (comment) ,

@Saul2022
Copy link
Author

Saul2022 commented Jan 9, 2025

Can you confirm that this only happens in 4.4 dev 3 and later, but not in 4.4 dev 2, dev 1, or 4.3 stable?

Tested and both 4.4 dev1 and 4.4 dev 2 can open and play the tps demo just fine. Will test all dev versiona and gradually tell.

Edit: starting with dev 4 the project crashes before loading the editor so it is starting with dev 4 where the crash happens

Then as for the project crashing after pressing the restart play button does not happen at all in dev 2, even though there's no crash, there is just a black screen. Meanwhile it's not possible on dev 1 as there's no pIp button to minimize the window, to press the restart play mode button.

@m4gr3d
Copy link
Contributor

m4gr3d commented Jan 13, 2025

Can you confirm that this only happens in 4.4 dev 3 and later, but not in 4.4 dev 2, dev 1, or 4.3 stable?

Tested and both 4.4 dev1 and 4.4 dev 2 can open and play the tps demo just fine. Will test all dev versiona and gradually tell.

Edit: starting with dev 4 the project crashes before loading the editor so it is starting with dev 4 where the crash happens

Then as for the project crashing after pressing the restart play button does not happen at all in dev 2, even though there's no crash, there is just a black screen. Meanwhile it's not possible on dev 1 as there's no pIp button to minimize the window, to press the restart play mode button.

Crashing from dev 4 may point to an issue with swappy as it was merged then via #96439.

cc @darksylinc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants