Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling "Script Editor" editor feature causes external script editor to not auto-launch #99308

Open
Anixias opened this issue Nov 16, 2024 · 8 comments

Comments

@Anixias
Copy link

Anixias commented Nov 16, 2024

Tested versions

v4.4.dev4.mono.official [36e6207]

System information

Godot v4.4.dev4.mono - Windows 10.0.22631 - Multi-window, 2 monitors - OpenGL 3 (Compatibility) - NVIDIA GeForce RTX 4070 Ti SUPER (NVIDIA; 32.0.15.6614) - 13th Gen Intel(R) Core(TM) i9-13900K (32 threads)

Issue description

Disabling the "Script Editor" editor feature prevents Godot from launching the configured external editor.

In my case, I use C# and JetBrains Rider. If I have the Script Editor feature enabled, clicking the script icon in a scene correctly opens Rider, but if I disable the Script Editor feature, clicking the script icon no longer has any effect.

Steps to reproduce

  1. Go to Editor > Manage Editor Features...
  2. Under "Main Features:", disable the "Script Editor" feature
  3. Try opening a C# script by clicking the script icon on a node in the scene hierarchy

Minimal reproduction project (MRP)

N/A

@AThousandShips

This comment was marked as resolved.

@eobet
Copy link
Contributor

eobet commented Nov 16, 2024

I don't know how to test that fix, but I just noticed that both the 2D and AssetLib main features show up in 4.4 dev4 even though they were properly disabled in 4.4 dev3 for me (the Script however, stayed disabled).

@AThousandShips
Copy link
Member

You can download the latest artifacts from master or build from source

But those bugs were also reported on dev4 and were fixed after dev4

@eobet
Copy link
Contributor

eobet commented Nov 16, 2024

Thanks, however that crashes on my project so I'll stay on dev3 for now and hope that the missing context menu items I saw in dev4 are also fixed.

@Anixias
Copy link
Author

Anixias commented Nov 16, 2024

The fix from #98988 shouldn't affect the external script editor bug I described above because it wasn't reordered in the enum in the first place. Would you like me to edit the issue to only be about that bug?

@AThousandShips
Copy link
Member

Please do, but try to replicate the bug in a more recent version to get details, or test dev3 to confirm it doesn't occur there

@Anixias Anixias changed the title [4.4 dev4] Disabling certain editor features breaks unrelated functionality [4.4 dev4] Disabling "Script Editor" editor feature causes external script editor to not auto-launch Nov 17, 2024
@Anixias
Copy link
Author

Anixias commented Nov 17, 2024

I was able to confirm the issue back in 4.3 stable, so it is not specific to dev4.

@Anixias Anixias changed the title [4.4 dev4] Disabling "Script Editor" editor feature causes external script editor to not auto-launch Disabling "Script Editor" editor feature causes external script editor to not auto-launch Nov 17, 2024
@AThousandShips
Copy link
Member

I didn't quite catch what the original issue was due to the other details, this is not necessarily a bug but an aspect of this feature, disabling scripting disables scripting entirely

For context:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants