From 501fc1a6ff4838f0df241797690c15028877fbd3 Mon Sep 17 00:00:00 2001 From: Stuart Carnie Date: Mon, 6 Jan 2025 07:46:51 -0700 Subject: [PATCH] Editor: Fix crash when using `--import --verbose` due to use-after-free --- editor/editor_resource_preview.cpp | 8 ++++++++ editor/editor_resource_preview.h | 1 + 2 files changed, 9 insertions(+) diff --git a/editor/editor_resource_preview.cpp b/editor/editor_resource_preview.cpp index a3712768adc8..f53f2744a225 100644 --- a/editor/editor_resource_preview.cpp +++ b/editor/editor_resource_preview.cpp @@ -522,6 +522,14 @@ void EditorResourcePreview::_bind_methods() { ADD_SIGNAL(MethodInfo("preview_invalidated", PropertyInfo(Variant::STRING, "path"))); } +void EditorResourcePreview::_notification(int p_what) { + switch (p_what) { + case NOTIFICATION_EXIT_TREE: { + stop(); + } break; + } +} + void EditorResourcePreview::check_for_invalidation(const String &p_path) { bool call_invalidated = false; { diff --git a/editor/editor_resource_preview.h b/editor/editor_resource_preview.h index 876b42b101d0..e901000d765c 100644 --- a/editor/editor_resource_preview.h +++ b/editor/editor_resource_preview.h @@ -123,6 +123,7 @@ class EditorResourcePreview : public Node { void _update_thumbnail_sizes(); protected: + void _notification(int p_what); static void _bind_methods(); public: