Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Instagram service settings #13457

Open
jmooring opened this issue Feb 27, 2025 · 0 comments
Open

Remove unused Instagram service settings #13457

jmooring opened this issue Feb 27, 2025 · 0 comments

Comments

@jmooring
Copy link
Member

We stopped using these Instagram service settings a year ago in v0.123.0:

[services.instagram]vice
  accessToken = ''
  disableInlineCSS = false

I'd like to remove them because of their presence in the docs.yaml file. They no longer belong in the documentation, and I dislike manually creating config examples because we have to remember to update them in the future, which we won't.

We could either:

  1. Silently remove them
  2. Log deprecation messages

INFO deprecated: the services.instagram.accessToken configuration setting was deprecated in Hugo 0.144.0 and will be removed in a future release. This setting is no longer used by the embedded Instagram shortcode. You may remove it from your site configuration."

I can think of two (somewhat flimsy) reasons to log deprecation messages:

  1. There's a very small chance that someone is using these settings with their custom Instagram shortcode
  2. It would give users notice to clean up their site config

I'd prefer to just silently remove the settings and be done with it. Anyone who has a custom shortcode that uses those settings will see an informative error (can't evaluate field Foo in type services.Instagram).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant