Fix error return from HMAC signing method (#371)

ss49919201 · web-flow · commit 6bcdd9d5b6ec · 2024-01-25T22:10:11.000-05:00
diff --git a/hmac.go b/hmac.go
@@ -91,7 +91,7 @@ func (m *SigningMethodHMAC) Verify(signingString string, sig []byte, key interfa
 func (m *SigningMethodHMAC) Sign(signingString string, key interface{}) ([]byte, error) {
 	if keyBytes, ok := key.([]byte); ok {
 		if !m.Hash.Available() {
-			return nil, newError("HMAC sign expects []byte", ErrInvalidKeyType)
+			return nil, ErrHashUnavailable
 		}
 
 		hasher := hmac.New(m.Hash.New, keyBytes)
@@ -100,5 +100,5 @@ func (m *SigningMethodHMAC) Sign(signingString string, key interface{}) ([]byte,
 		return hasher.Sum(nil), nil
 	}
 
-	return nil, ErrInvalidKeyType
+	return nil, newError("HMAC sign expects []byte", ErrInvalidKeyType)
 }

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func (m *SigningMethodHMAC) Verify(signingString string, sig []byte, key interfa`
`91`	`91`	`func (m *SigningMethodHMAC) Sign(signingString string, key interface{}) ([]byte, error) {`
`92`	`92`	`if keyBytes, ok := key.([]byte); ok {`
`93`	`93`	`if !m.Hash.Available() {`
`94`		`- return nil, newError("HMAC sign expects []byte", ErrInvalidKeyType)`
	`94`	`+ return nil, ErrHashUnavailable`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`hasher := hmac.New(m.Hash.New, keyBytes)`
`@@ -100,5 +100,5 @@ func (m *SigningMethodHMAC) Sign(signingString string, key interface{}) ([]byte,`
`100`	`100`	`return hasher.Sum(nil), nil`
`101`	`101`	`}`
`102`	`102`
`103`		`- return nil, ErrInvalidKeyType`
	`103`	`+ return nil, newError("HMAC sign expects []byte", ErrInvalidKeyType)`
`104`	`104`	`}`