x/crypto/blake2b: test build fails

[kevinburke]

Please answer these questions before submitting your issue. Thanks!

What did you do?

Compile Go at tip (58c231f)

cd $GOPATH/src/golang.org/x/crypto
git pull origin master # (golang/crypto@b0697eccbea9adec5b7ba8008f4c33d98d733388)
go test ./blake2b

What did you expect to see?

Test pass (or test failure)

What did you see instead?

Compile failure:

$ go test ./blake2b
# golang.org/x/crypto/blake2b.test
golang.org/x/crypto/blake2b.supportsAVX2: relocation target runtime.support_avx2 not defined
golang.org/x/crypto/blake2b.supportsAVX: relocation target runtime.support_avx not defined
golang.org/x/crypto/blake2b.supportsAVX2: undefined: "runtime.support_avx2"
golang.org/x/crypto/blake2b.supportsAVX: undefined: "runtime.support_avx"
FAIL	golang.org/x/crypto/blake2b [build failed]

Does this issue reproduce with the latest release (go1.10.1)?

No. It also does not reproduce with go build ./blake2b.

System details

go version devel +58c231f244 Thu Apr 26 03:54:19 2018 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/kevin/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/kevin"
GORACE=""
GOROOT="/Users/kevin/go"
GOTMPDIR=""
GOTOOLDIR="/Users/kevin/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sf/fsn3_vgd0n98r0jb86bgp83r0000gn/T/go-build178385163=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version devel +58c231f244 Thu Apr 26 03:54:19 2018 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +58c231f244 Thu Apr 26 03:54:19 2018 +0000
uname -v: Darwin Kernel Version 17.5.0: Mon Mar  5 22:24:32 PST 2018; root:xnu-4570.51.1~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.4
BuildVersion:	17E199
lldb --version: lldb-900.0.57
  Swift-4.0

[agnivade]

This is because of https://go-review.googlesource.com/c/crypto/+/108795 and #24828

[gopherbot]

Change https://golang.org/cl/110016 mentions this issue: blake2b: stub out values removed from runtime

[FiloSottile]

Fixed by golang/crypto@ae8bce0.