Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/cmd: TestImplementations failures #72082

Open
gopherbot opened this issue Mar 3, 2025 · 3 comments
Open

x/tools/gopls/internal/cmd: TestImplementations failures #72082

gopherbot opened this issue Mar 3, 2025 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-03 14:37 x_tools-gotip-freebsd-amd64-race tools@0efa5e51 go@0312e31e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 3, 2025
@gopherbot gopherbot added this to the Unreleased milestone Mar 3, 2025
@adonovan
Copy link
Member

adonovan commented Mar 3, 2025

Dup of #71817 (types.CheckExpr mutates objects => data race)

@adonovan adonovan closed this as completed Mar 3, 2025
@gopherbot gopherbot reopened this Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-03 20:04 x_tools-go1.23-linux-arm64-race tools@0ffdb82e release-branch.go1.23@e4772831 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00f47e52a by goroutine 6132:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (22.34s)

— watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Active
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@adonovan @gopherbot