You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
src/goLanguageServer: disable language service on guest side completely
The language client library sends workspace folder with vsls uri scheme
which makes gopls unhappy. According to LiveShare guideline
https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/extensions#visual-studio-code-1
"Guests receive the language service results from both their local
extensions, and the host, and therefore, if both participants have the
same language service extension installed, guests will see duplicate
entries for certain things (e.g. auto-completion, code actions)"
That implies the language service on the guest side is unnecessary.
Actually, excluding all the go files, there is no reason to start the
language server at all.
Manually tested.
Fixes#605Fixes#1024
Change-Id: Ib9e72fe848a202c9e3cc9aa4d183a2919cf07797
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/277392
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
0 commit comments