Fixes incorrect error code for vendor U2F

kaczmarczyck · kaczmarczyck · commit 645a059d124d · 2024-10-01T15:08:51.000+02:00
diff --git a/libraries/opensk/src/ctap/ctap1.rs b/libraries/opensk/src/ctap/ctap1.rs
@@ -233,8 +233,7 @@ impl Ctap1Command {
             // U2F raw message format specification (version 20170411) section 6.3
             U2fCommand::Version => Ok(Vec::<u8>::from(super::U2F_VERSION_STRING)),
 
-            // TODO: should we return an error instead such as SW_INS_NOT_SUPPORTED?
-            U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_SUCCESS),
+            U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_INS_INVALID),
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -233,8 +233,7 @@ impl Ctap1Command {`
`233`	`233`	`// U2F raw message format specification (version 20170411) section 6.3`
`234`	`234`	`U2fCommand::Version => Ok(Vec::<u8>::from(super::U2F_VERSION_STRING)),`
`235`	`235`
`236`		`- // TODO: should we return an error instead such as SW_INS_NOT_SUPPORTED?`
`237`		`- U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_SUCCESS),`
	`236`	`+ U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_INS_INVALID),`
`238`	`237`	`}`
`239`	`238`	`}`
`240`	`239`