Skip to content
This repository was archived by the owner on Apr 17, 2024. It is now read-only.

Commit 3ab33de

Browse files
LizaTretyakovacopybara-github
authored andcommittedDec 16, 2022
Fix wrapper registration in Factory classes.
In preparation to the switch in the Registry where MutablePrimitiveRegistry will be used under the hood for wrapper registration, and this does not tolerate when a different wrapper object is attempted to be registered for a primitive class for which a wrapper object is already registered. PiperOrigin-RevId: 495866076
1 parent ef35b97 commit 3ab33de

13 files changed

+8
-30
lines changed
 

‎java_src/src/main/java/com/google/crypto/tink/aead/AeadFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.google.crypto.tink.Aead;
2020
import com.google.crypto.tink.KeysetHandle;
21-
import com.google.crypto.tink.Registry;
2221
import java.security.GeneralSecurityException;
2322

2423
/**
@@ -46,7 +45,7 @@ public final class AeadFactory {
4645
*/
4746
@Deprecated
4847
public static Aead getPrimitive(KeysetHandle keysetHandle) throws GeneralSecurityException {
49-
Registry.registerPrimitiveWrapper(new AeadWrapper());
48+
AeadWrapper.register();
5049
return keysetHandle.getPrimitive(Aead.class);
5150
}
5251

‎java_src/src/main/java/com/google/crypto/tink/aead/BUILD.bazel

-2
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ java_library(
9595
deps = [
9696
":aead_wrapper",
9797
"//src/main/java/com/google/crypto/tink:aead",
98-
"//src/main/java/com/google/crypto/tink:registry",
9998
"//src/main/java/com/google/crypto/tink:registry_cluster",
10099
],
101100
)
@@ -418,7 +417,6 @@ android_library(
418417
deps = [
419418
":aead_wrapper-android",
420419
"//src/main/java/com/google/crypto/tink:aead-android",
421-
"//src/main/java/com/google/crypto/tink:registry-android",
422420
"//src/main/java/com/google/crypto/tink:registry_cluster-android",
423421
],
424422
)

‎java_src/src/main/java/com/google/crypto/tink/daead/BUILD.bazel

-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ java_library(
3030
deps = [
3131
":deterministic_aead_wrapper",
3232
"//src/main/java/com/google/crypto/tink:deterministic_aead",
33-
"//src/main/java/com/google/crypto/tink:registry",
3433
"//src/main/java/com/google/crypto/tink:registry_cluster",
3534
],
3635
)
@@ -41,7 +40,6 @@ android_library(
4140
deps = [
4241
":deterministic_aead_wrapper-android",
4342
"//src/main/java/com/google/crypto/tink:deterministic_aead-android",
44-
"//src/main/java/com/google/crypto/tink:registry-android",
4543
"//src/main/java/com/google/crypto/tink:registry_cluster-android",
4644
],
4745
)

‎java_src/src/main/java/com/google/crypto/tink/daead/DeterministicAeadFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.google.crypto.tink.DeterministicAead;
2020
import com.google.crypto.tink.KeysetHandle;
21-
import com.google.crypto.tink.Registry;
2221
import java.security.GeneralSecurityException;
2322

2423
/**
@@ -46,7 +45,7 @@ public final class DeterministicAeadFactory {
4645
@Deprecated
4746
public static DeterministicAead getPrimitive(KeysetHandle keysetHandle)
4847
throws GeneralSecurityException {
49-
Registry.registerPrimitiveWrapper(new DeterministicAeadWrapper());
48+
DeterministicAeadWrapper.register();
5049
return keysetHandle.getPrimitive(DeterministicAead.class);
5150
}
5251

‎java_src/src/main/java/com/google/crypto/tink/hybrid/BUILD.bazel

-4
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ java_library(
157157
deps = [
158158
":hybrid_decrypt_wrapper",
159159
"//src/main/java/com/google/crypto/tink:hybrid_decrypt",
160-
"//src/main/java/com/google/crypto/tink:registry",
161160
"//src/main/java/com/google/crypto/tink:registry_cluster",
162161
],
163162
)
@@ -168,7 +167,6 @@ java_library(
168167
deps = [
169168
":hybrid_encrypt_wrapper",
170169
"//src/main/java/com/google/crypto/tink:hybrid_encrypt",
171-
"//src/main/java/com/google/crypto/tink:registry",
172170
"//src/main/java/com/google/crypto/tink:registry_cluster",
173171
],
174172
)
@@ -337,7 +335,6 @@ android_library(
337335
deps = [
338336
":hybrid_decrypt_wrapper-android",
339337
"//src/main/java/com/google/crypto/tink:hybrid_decrypt-android",
340-
"//src/main/java/com/google/crypto/tink:registry-android",
341338
"//src/main/java/com/google/crypto/tink:registry_cluster-android",
342339
],
343340
)
@@ -348,7 +345,6 @@ android_library(
348345
deps = [
349346
":hybrid_encrypt_wrapper-android",
350347
"//src/main/java/com/google/crypto/tink:hybrid_encrypt-android",
351-
"//src/main/java/com/google/crypto/tink:registry-android",
352348
"//src/main/java/com/google/crypto/tink:registry_cluster-android",
353349
],
354350
)

‎java_src/src/main/java/com/google/crypto/tink/hybrid/HybridDecryptFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import com.google.crypto.tink.HybridDecrypt;
1919
import com.google.crypto.tink.KeysetHandle;
20-
import com.google.crypto.tink.Registry;
2120
import java.security.GeneralSecurityException;
2221

2322
/**
@@ -45,7 +44,7 @@ public final class HybridDecryptFactory {
4544
@Deprecated
4645
public static HybridDecrypt getPrimitive(KeysetHandle keysetHandle)
4746
throws GeneralSecurityException {
48-
Registry.registerPrimitiveWrapper(new HybridDecryptWrapper());
47+
HybridDecryptWrapper.register();
4948
return keysetHandle.getPrimitive(HybridDecrypt.class);
5049
}
5150

‎java_src/src/main/java/com/google/crypto/tink/hybrid/HybridEncryptFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import com.google.crypto.tink.HybridEncrypt;
1919
import com.google.crypto.tink.KeysetHandle;
20-
import com.google.crypto.tink.Registry;
2120
import java.security.GeneralSecurityException;
2221

2322
/**
@@ -46,7 +45,7 @@ public final class HybridEncryptFactory {
4645
@Deprecated
4746
public static HybridEncrypt getPrimitive(KeysetHandle keysetHandle)
4847
throws GeneralSecurityException {
49-
Registry.registerPrimitiveWrapper(new HybridEncryptWrapper());
48+
HybridEncryptWrapper.register();
5049
return keysetHandle.getPrimitive(HybridEncrypt.class);
5150
}
5251

‎java_src/src/main/java/com/google/crypto/tink/mac/MacFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.google.crypto.tink.KeysetHandle;
2020
import com.google.crypto.tink.Mac;
21-
import com.google.crypto.tink.Registry;
2221
import java.security.GeneralSecurityException;
2322

2423
/**
@@ -47,7 +46,7 @@ public final class MacFactory {
4746
*/
4847
@Deprecated
4948
public static Mac getPrimitive(KeysetHandle keysetHandle) throws GeneralSecurityException {
50-
Registry.registerPrimitiveWrapper(new MacWrapper());
49+
MacWrapper.register();
5150
return keysetHandle.getPrimitive(Mac.class);
5251
}
5352

‎java_src/src/main/java/com/google/crypto/tink/signature/BUILD.bazel

-4
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ java_library(
176176
deps = [
177177
":public_key_sign_wrapper",
178178
"//src/main/java/com/google/crypto/tink:public_key_sign",
179-
"//src/main/java/com/google/crypto/tink:registry",
180179
"//src/main/java/com/google/crypto/tink:registry_cluster",
181180
],
182181
)
@@ -274,7 +273,6 @@ java_library(
274273
deps = [
275274
":public_key_verify_wrapper",
276275
"//src/main/java/com/google/crypto/tink:public_key_verify",
277-
"//src/main/java/com/google/crypto/tink:registry",
278276
"//src/main/java/com/google/crypto/tink:registry_cluster",
279277
],
280278
)
@@ -532,7 +530,6 @@ android_library(
532530
deps = [
533531
":public_key_sign_wrapper-android",
534532
"//src/main/java/com/google/crypto/tink:public_key_sign-android",
535-
"//src/main/java/com/google/crypto/tink:registry-android",
536533
"//src/main/java/com/google/crypto/tink:registry_cluster-android",
537534
],
538535
)
@@ -630,7 +627,6 @@ android_library(
630627
deps = [
631628
":public_key_verify_wrapper-android",
632629
"//src/main/java/com/google/crypto/tink:public_key_verify-android",
633-
"//src/main/java/com/google/crypto/tink:registry-android",
634630
"//src/main/java/com/google/crypto/tink:registry_cluster-android",
635631
],
636632
)

‎java_src/src/main/java/com/google/crypto/tink/signature/PublicKeySignFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.google.crypto.tink.KeysetHandle;
2020
import com.google.crypto.tink.PublicKeySign;
21-
import com.google.crypto.tink.Registry;
2221
import java.security.GeneralSecurityException;
2322

2423
/**
@@ -46,7 +45,7 @@ public final class PublicKeySignFactory {
4645
@Deprecated
4746
public static PublicKeySign getPrimitive(KeysetHandle keysetHandle)
4847
throws GeneralSecurityException {
49-
Registry.registerPrimitiveWrapper(new PublicKeySignWrapper());
48+
PublicKeySignWrapper.register();
5049
return keysetHandle.getPrimitive(PublicKeySign.class);
5150
}
5251

‎java_src/src/main/java/com/google/crypto/tink/signature/PublicKeyVerifyFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.google.crypto.tink.KeysetHandle;
2020
import com.google.crypto.tink.PublicKeyVerify;
21-
import com.google.crypto.tink.Registry;
2221
import java.security.GeneralSecurityException;
2322

2423
/**
@@ -46,7 +45,7 @@ public final class PublicKeyVerifyFactory {
4645
@Deprecated
4746
public static PublicKeyVerify getPrimitive(KeysetHandle keysetHandle)
4847
throws GeneralSecurityException {
49-
Registry.registerPrimitiveWrapper(new PublicKeyVerifyWrapper());
48+
PublicKeyVerifyWrapper.register();
5049
return keysetHandle.getPrimitive(PublicKeyVerify.class);
5150
}
5251

‎java_src/src/main/java/com/google/crypto/tink/streamingaead/BUILD.bazel

-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ java_library(
7676
srcs = ["StreamingAeadFactory.java"],
7777
deps = [
7878
":streaming_aead_wrapper",
79-
"//src/main/java/com/google/crypto/tink:registry",
8079
"//src/main/java/com/google/crypto/tink:registry_cluster",
8180
"//src/main/java/com/google/crypto/tink:streaming_aead",
8281
],
@@ -220,7 +219,6 @@ android_library(
220219
srcs = ["StreamingAeadFactory.java"],
221220
deps = [
222221
":streaming_aead_wrapper-android",
223-
"//src/main/java/com/google/crypto/tink:registry-android",
224222
"//src/main/java/com/google/crypto/tink:registry_cluster-android",
225223
"//src/main/java/com/google/crypto/tink:streaming_aead-android",
226224
],

‎java_src/src/main/java/com/google/crypto/tink/streamingaead/StreamingAeadFactory.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.google.crypto.tink.streamingaead;
1818

1919
import com.google.crypto.tink.KeysetHandle;
20-
import com.google.crypto.tink.Registry;
2120
import com.google.crypto.tink.StreamingAead;
2221
import java.security.GeneralSecurityException;
2322

@@ -43,7 +42,7 @@ public final class StreamingAeadFactory {
4342
*/
4443
public static StreamingAead getPrimitive(KeysetHandle keysetHandle)
4544
throws GeneralSecurityException {
46-
Registry.registerPrimitiveWrapper(new StreamingAeadWrapper());
45+
StreamingAeadWrapper.register();
4746
return keysetHandle.getPrimitive(StreamingAead.class);
4847
}
4948

0 commit comments

Comments
 (0)
This repository has been archived.