Skip to content

Commit 3b5db4d

Browse files
authored
fix(gengapic): switch regapic use of xerrors to fmt for wrapping (#902)
1 parent 1c955a6 commit 3b5db4d

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

internal/gengapic/doc_file.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ func (g *generator) genDocFile(year int, scopes []string, serv *descriptor.Servi
111111
p("import (")
112112
p("%s%q", "\t", "context")
113113
if hasREST {
114+
p("%s%q", "\t", "fmt")
114115
p("%s%q", "\t", "net/http")
115116
}
116117
p("%s%q", "\t", "os")
@@ -119,9 +120,6 @@ func (g *generator) genDocFile(year int, scopes []string, serv *descriptor.Servi
119120
p("%s%q", "\t", "strings")
120121
p("%s%q", "\t", "unicode")
121122
p("")
122-
if hasREST {
123-
p("%s%q", "\t", "golang.org/x/xerrors")
124-
}
125123
p("%s%q", "\t", "google.golang.org/api/option")
126124
p("%s%q", "\t", "google.golang.org/grpc/metadata")
127125
p(")")
@@ -215,7 +213,7 @@ func (g *generator) genDocFile(year int, scopes []string, serv *descriptor.Servi
215213
p("// of receiving an unknown enum value.")
216214
p("func maybeUnknownEnum(err error) error {")
217215
p(` if strings.Contains(err.Error(), "invalid value for enum type") {`)
218-
p(` err = xerrors.Errorf("received an unknown enum value; a later version of the library may support it: %%w", err)`)
216+
p(` err = fmt.Errorf("received an unknown enum value; a later version of the library may support it: %%w", err)`)
219217
p(" }")
220218
p(" return err")
221219
p("}")

internal/gengapic/testdata/doc_file.want

+2-2
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,14 @@ package awesome // import "path/to/awesome"
7171

7272
import (
7373
"context"
74+
"fmt"
7475
"net/http"
7576
"os"
7677
"runtime"
7778
"strconv"
7879
"strings"
7980
"unicode"
8081

81-
"golang.org/x/xerrors"
8282
"google.golang.org/api/option"
8383
"google.golang.org/grpc/metadata"
8484
)
@@ -160,7 +160,7 @@ func versionGo() string {
160160
// of receiving an unknown enum value.
161161
func maybeUnknownEnum(err error) error {
162162
if strings.Contains(err.Error(), "invalid value for enum type") {
163-
err = xerrors.Errorf("received an unknown enum value; a later version of the library may support it: %w", err)
163+
err = fmt.Errorf("received an unknown enum value; a later version of the library may support it: %w", err)
164164
}
165165
return err
166166
}

internal/gengapic/testdata/doc_file_alpha.want

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ package awesome // import "path/to/awesome"
7373

7474
import (
7575
"context"
76+
"fmt"
7677
"net/http"
7778
"os"
7879
"runtime"
7980
"strconv"
8081
"strings"
8182
"unicode"
8283

83-
"golang.org/x/xerrors"
8484
"google.golang.org/api/option"
8585
"google.golang.org/grpc/metadata"
8686
)
@@ -162,7 +162,7 @@ func versionGo() string {
162162
// of receiving an unknown enum value.
163163
func maybeUnknownEnum(err error) error {
164164
if strings.Contains(err.Error(), "invalid value for enum type") {
165-
err = xerrors.Errorf("received an unknown enum value; a later version of the library may support it: %w", err)
165+
err = fmt.Errorf("received an unknown enum value; a later version of the library may support it: %w", err)
166166
}
167167
return err
168168
}

internal/gengapic/testdata/doc_file_beta.want

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ package awesome // import "path/to/awesome"
7373

7474
import (
7575
"context"
76+
"fmt"
7677
"net/http"
7778
"os"
7879
"runtime"
7980
"strconv"
8081
"strings"
8182
"unicode"
8283

83-
"golang.org/x/xerrors"
8484
"google.golang.org/api/option"
8585
"google.golang.org/grpc/metadata"
8686
)
@@ -162,7 +162,7 @@ func versionGo() string {
162162
// of receiving an unknown enum value.
163163
func maybeUnknownEnum(err error) error {
164164
if strings.Contains(err.Error(), "invalid value for enum type") {
165-
err = xerrors.Errorf("received an unknown enum value; a later version of the library may support it: %w", err)
165+
err = fmt.Errorf("received an unknown enum value; a later version of the library may support it: %w", err)
166166
}
167167
return err
168168
}

0 commit comments

Comments
 (0)