Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Commit 4bdad82

Browse files
fix: Add async context manager return types (#571)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b3f18d0f6560a855022fd058865e7620479d7af9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 4cbc45b commit 4bdad82

File tree

7 files changed

+44
-26
lines changed

7 files changed

+44
-26
lines changed

google/cloud/asset_v1/services/asset_service/async_client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3224,7 +3224,7 @@ async def get_operation(
32243224
# Done; return the response.
32253225
return response
32263226

3227-
async def __aenter__(self):
3227+
async def __aenter__(self) -> "AssetServiceAsyncClient":
32283228
return self
32293229

32303230
async def __aexit__(self, exc_type, exc, tb):

google/cloud/asset_v1p1beta1/services/asset_service/async_client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ async def sample_search_all_iam_policies():
513513
# Done; return the response.
514514
return response
515515

516-
async def __aenter__(self):
516+
async def __aenter__(self) -> "AssetServiceAsyncClient":
517517
return self
518518

519519
async def __aexit__(self, exc_type, exc, tb):

google/cloud/asset_v1p2beta1/services/asset_service/async_client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -775,7 +775,7 @@ async def sample_delete_feed():
775775
metadata=metadata,
776776
)
777777

778-
async def __aenter__(self):
778+
async def __aenter__(self) -> "AssetServiceAsyncClient":
779779
return self
780780

781781
async def __aexit__(self, exc_type, exc, tb):

google/cloud/asset_v1p5beta1/services/asset_service/async_client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ async def sample_list_assets():
346346
# Done; return the response.
347347
return response
348348

349-
async def __aenter__(self):
349+
async def __aenter__(self) -> "AssetServiceAsyncClient":
350350
return self
351351

352352
async def __aexit__(self, exc_type, exc, tb):

tests/unit/gapic/asset_v1/test_asset_service.py

+28-16
Original file line numberDiff line numberDiff line change
@@ -1258,9 +1258,11 @@ async def test_list_assets_async_pages():
12581258
RuntimeError,
12591259
)
12601260
pages = []
1261-
async for page_ in (
1261+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1262+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1263+
async for page_ in ( # pragma: no branch
12621264
await client.list_assets(request={})
1263-
).pages: # pragma: no branch
1265+
).pages:
12641266
pages.append(page_)
12651267
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
12661268
assert page_.raw_page.next_page_token == token
@@ -3054,9 +3056,11 @@ async def test_search_all_resources_async_pages():
30543056
RuntimeError,
30553057
)
30563058
pages = []
3057-
async for page_ in (
3059+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
3060+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
3061+
async for page_ in ( # pragma: no branch
30583062
await client.search_all_resources(request={})
3059-
).pages: # pragma: no branch
3063+
).pages:
30603064
pages.append(page_)
30613065
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
30623066
assert page_.raw_page.next_page_token == token
@@ -3507,9 +3511,11 @@ async def test_search_all_iam_policies_async_pages():
35073511
RuntimeError,
35083512
)
35093513
pages = []
3510-
async for page_ in (
3514+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
3515+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
3516+
async for page_ in ( # pragma: no branch
35113517
await client.search_all_iam_policies(request={})
3512-
).pages: # pragma: no branch
3518+
).pages:
35133519
pages.append(page_)
35143520
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
35153521
assert page_.raw_page.next_page_token == token
@@ -3997,7 +4003,6 @@ def test_query_assets(request_type, transport: str = "grpc"):
39974003
call.return_value = asset_service.QueryAssetsResponse(
39984004
job_reference="job_reference_value",
39994005
done=True,
4000-
error=status_pb2.Status(code=411),
40014006
)
40024007
response = client.query_assets(request)
40034008

@@ -5085,9 +5090,11 @@ async def test_list_saved_queries_async_pages():
50855090
RuntimeError,
50865091
)
50875092
pages = []
5088-
async for page_ in (
5093+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
5094+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
5095+
async for page_ in ( # pragma: no branch
50895096
await client.list_saved_queries(request={})
5090-
).pages: # pragma: no branch
5097+
).pages:
50915098
pages.append(page_)
50925099
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
50935100
assert page_.raw_page.next_page_token == token
@@ -6211,9 +6218,11 @@ async def test_analyze_org_policies_async_pages():
62116218
RuntimeError,
62126219
)
62136220
pages = []
6214-
async for page_ in (
6221+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
6222+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
6223+
async for page_ in ( # pragma: no branch
62156224
await client.analyze_org_policies(request={})
6216-
).pages: # pragma: no branch
6225+
).pages:
62176226
pages.append(page_)
62186227
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
62196228
assert page_.raw_page.next_page_token == token
@@ -6686,9 +6695,11 @@ async def test_analyze_org_policy_governed_containers_async_pages():
66866695
RuntimeError,
66876696
)
66886697
pages = []
6689-
async for page_ in (
6698+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
6699+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
6700+
async for page_ in ( # pragma: no branch
66906701
await client.analyze_org_policy_governed_containers(request={})
6691-
).pages: # pragma: no branch
6702+
).pages:
66926703
pages.append(page_)
66936704
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
66946705
assert page_.raw_page.next_page_token == token
@@ -7159,9 +7170,11 @@ async def test_analyze_org_policy_governed_assets_async_pages():
71597170
RuntimeError,
71607171
)
71617172
pages = []
7162-
async for page_ in (
7173+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
7174+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
7175+
async for page_ in ( # pragma: no branch
71637176
await client.analyze_org_policy_governed_assets(request={})
7164-
).pages: # pragma: no branch
7177+
).pages:
71657178
pages.append(page_)
71667179
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
71677180
assert page_.raw_page.next_page_token == token
@@ -10692,7 +10705,6 @@ def test_query_assets_rest(request_type):
1069210705
return_value = asset_service.QueryAssetsResponse(
1069310706
job_reference="job_reference_value",
1069410707
done=True,
10695-
error=status_pb2.Status(code=411),
1069610708
)
1069710709

1069810710
# Wrap the value into a proper Response obj

tests/unit/gapic/asset_v1p1beta1/test_asset_service.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -1148,9 +1148,11 @@ async def test_search_all_resources_async_pages():
11481148
RuntimeError,
11491149
)
11501150
pages = []
1151-
async for page_ in (
1151+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1152+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1153+
async for page_ in ( # pragma: no branch
11521154
await client.search_all_resources(request={})
1153-
).pages: # pragma: no branch
1155+
).pages:
11541156
pages.append(page_)
11551157
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11561158
assert page_.raw_page.next_page_token == token
@@ -1601,9 +1603,11 @@ async def test_search_all_iam_policies_async_pages():
16011603
RuntimeError,
16021604
)
16031605
pages = []
1604-
async for page_ in (
1606+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1607+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1608+
async for page_ in ( # pragma: no branch
16051609
await client.search_all_iam_policies(request={})
1606-
).pages: # pragma: no branch
1610+
).pages:
16071611
pages.append(page_)
16081612
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
16091613
assert page_.raw_page.next_page_token == token

tests/unit/gapic/asset_v1p5beta1/test_asset_service.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -1106,9 +1106,11 @@ async def test_list_assets_async_pages():
11061106
RuntimeError,
11071107
)
11081108
pages = []
1109-
async for page_ in (
1109+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1110+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1111+
async for page_ in ( # pragma: no branch
11101112
await client.list_assets(request={})
1111-
).pages: # pragma: no branch
1113+
).pages:
11121114
pages.append(page_)
11131115
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11141116
assert page_.raw_page.next_page_token == token

0 commit comments

Comments
 (0)