Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bump-patch-for-minor-pre-major option #365

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

ilya-lesikov
Copy link
Contributor

@ilya-lesikov ilya-lesikov commented Sep 13, 2021

Pass bump-patch-for-minor-pre-major to release-please to allow bumping
patch versions instead of minors for feat changes. Disabled by default. Change is backwards compatible.

This functionality was broken in release-please until now: googleapis/release-please#1049
I suppose the fix should be in the new release of release-please soon.

Signed-off-by: Ilya Lesikov ilya@lesikov.com

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Pass bump-patch-for-minor-pre-major to release-please to allow bumping
patch versions instead of minors for feat changes. Disabled by default.

Signed-off-by: Ilya Lesikov <ilya@lesikov.com>
@google-cla google-cla bot added the cla: yes label Sep 13, 2021
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be fixed in the latest release of release-please, could I bother you to upate the version in package.json as well?

@ilya-lesikov
Copy link
Contributor Author

Updated, I hope I didn't update too much in the lock file.

@ilya-lesikov ilya-lesikov requested a review from bcoe September 15, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants