feat: support proxy configuration #621
Merged
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
That1bull-BK
approved these changes
Oct 30, 2022
kalinowski-iag
approved these changes
Nov 8, 2022
|
Hi @chingor13, I was wondering if there is a chance this one is given some attention? There is a corresponding change already merged in the https://github.com/googleapis/release-please and it's causing a bit of discrepancy between the two. |
|
I'm unable to resolve the conflict in the PR. This PR needs to revert the conflicting files. |
liweiyi88
changed the title
|
@chingor13 , I have resolved the conflict. |
chingor13
approved these changes
Nov 9, 2022
This was referenced Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our recent efforts to the upstream google release please package (googleapis/release-please#1639 and googleapis/release-please#1655) We are now able to configure the proxy settings in an easy way.
This PR exposes the proxy configuration to the action users and is helpful for users who run the action behind a proxy server.
This PR will resolve #458 and #629 as well