Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any and specify types in the editor #695

Open
sehilyi opened this issue May 17, 2022 · 2 comments
Open

Remove any and specify types in the editor #695

sehilyi opened this issue May 17, 2022 · 2 comments
Labels
maintenance Related to maintenance of project

Comments

@sehilyi
Copy link
Member

sehilyi commented May 17, 2022

Was just poking around with the editor to expose some of this Twitter behavior, cleaned up a few things. A general observation is that there is liberal use of any, which makes TS utility extremely limited here.

Originally posted by @manzt in #692 (comment)

@sehilyi sehilyi added the maintenance Related to maintenance of project label May 17, 2022
@sehilyi
Copy link
Member Author

sehilyi commented May 19, 2022

Actually, this is an issue in the repo in general (not specific to the editor). I will continuously remove any when updating codes.

We will eventually need type definitions for HiGlass-related functions/variables, such as BarTrack which is a parent class of gosling-track.

@manzt
Copy link
Member

manzt commented May 19, 2022

That's a great idea, especially as we built out Gosling further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Related to maintenance of project
Projects
None yet
Development

No branches or pull requests

2 participants