Skip to content

Commit 308c1fc

Browse files
committed
fix(build): fix image tags to work with helm
1 parent 0dd8620 commit 308c1fc

File tree

3 files changed

+32
-27
lines changed

3 files changed

+32
-27
lines changed

.github/workflows/docker.yml

+6
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ jobs:
5050
- name: set version
5151
run: just set-version
5252

53+
- name: get version
54+
id: version
55+
run: echo "version=$(just --evaluate version)" >> "${GITHUB_OUTPUT}"
56+
5357
- name: meta
5458
id: meta
5559
uses: docker/metadata-action@v5
@@ -58,6 +62,8 @@ jobs:
5862
${{ env.IMAGE }}
5963
tags: |
6064
type=ref,event=tag
65+
type=semver,pattern={{version}}
66+
type=raw,value=${{ steps.version.outputs.version }},enable=true
6167
type=raw,value=unstable,enable={{is_default_branch}}
6268
type=sha
6369

README.md

+8-27
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ You can:
1717

1818
1. Download the [cli][cli-download] and add it to your `$PATH`.
1919
1. Get a k8s cluster. [k3d][k3d] is a convenient way to get a cluster up and
20-
running fast. Follow their [installation] instructions and create a default
20+
running fast. Follow their installation instructions and create a default
2121
cluster.
2222
1. Grant your email address access to the cluster. Choose `cluster-admin` if
2323
you'd like something simple to check out how things work. For more details on
24-
the minimum possible permissions, read the [Authorization] section. The email
25-
address is what you'll be using to authenticate against. It can either be the
26-
one associated with a google or github account. Note, the ID used for login
27-
and the providers available can all be configured.
24+
the minimum possible permissions, read the [Authorization](#authorization)
25+
section. The email address is what you'll be using to authenticate against.
26+
It can either be the one associated with a google or github account. Note,
27+
the ID used for login and the providers available can all be configured.
2828

2929
```bash
3030
kuberift users grant <cluster-role> <email-address>
@@ -84,9 +84,9 @@ your cluster, you can run:
8484

8585
```bash
8686
helm install kuberift oci://ghcr.io/grampelberg/helm/kuberift \
87-
-n kuberift --create-namespace \
88-
--version $(curl -L https://api.github.com/repos/grampelberg/kuberift/tags | jq -r '.[0].name' | cut -c2-) \
89-
-f https://raw.githubusercontent.com/grampelberg/kuberift/main/helm/getting-started.yaml
87+
-n kuberift --create-namespace \
88+
--version $(curl -L https://api.github.com/repos/grampelberg/kuberift/tags | jq -r '.[0].name' | cut -c2-) \
89+
-f https://raw.githubusercontent.com/grampelberg/kuberift/main/helm/getting-started.yaml
9090
```
9191

9292
Note: this exposes the kuberift service externally by default. To get that IP
@@ -264,22 +264,3 @@ the design decisions section for an explanation of what's happening there.
264264

265265
- See releases for the latest tagged release.
266266
- The `unstable` tag is updated on every merge to main.
267-
268-
## TODO
269-
270-
- Groups are probably what most users are going to want to use to configure all
271-
this. The closest to the OpenID spec would be via adding extra scopes that add
272-
the data required to the token and then map back to a group. Imagine:
273-
274-
```yaml
275-
user: email
276-
group: https://myapp.example.com/group
277-
```
278-
279-
The downside to using this kind of configuration is that it'll need to be
280-
handled in the provider backend and it is unclear how easy that'll be. It is
281-
possible in auth0, so I'll go down this route for now.
282-
283-
- Is there a way to do FPS on a per-session basis with prometheus? Naively the
284-
way to do it would be to have a per-session label value, but that would be
285-
crazy for cardinality.

TODO.md

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
## TODO
2+
3+
- Groups are probably what most users are going to want to use to configure all
4+
this. The closest to the OpenID spec would be via adding extra scopes that add
5+
the data required to the token and then map back to a group. Imagine:
6+
7+
```yaml
8+
user: email
9+
group: https://myapp.example.com/group
10+
```
11+
12+
The downside to using this kind of configuration is that it'll need to be
13+
handled in the provider backend and it is unclear how easy that'll be. It is
14+
possible in auth0, so I'll go down this route for now.
15+
16+
- Is there a way to do FPS on a per-session basis with prometheus? Naively the
17+
way to do it would be to have a per-session label value, but that would be
18+
crazy for cardinality.

0 commit comments

Comments
 (0)