Support descriptions with param_attrs on field arguments with proc-macro
#428
Labels
duplicate
This issue or pull request already exists
enhancement
Improvement of existing features or bugfix
Comments
davidpdrsn
changed the title
param_attrs on field arguments with proc-macro
|
#421 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have been working on removing the use of
graphql_object!from juniper-from-schema in favour of the new proc macro. The process was pretty straight forward except for supporting descriptions on field arguments. The juniper docs mentions that cleaning that up is blocked by RFC 2564. However that RFC is now stabilised and will be included in 1.39 🎉I'm not sure if you want to require 1.39 for the next release, but since it'll include async/await I imagine most people are going to upgrade quickly. If you do wait until 1.40 I would appreciate it if you keep
graphql_object!around until then so juniper-from-schema doesn't get stuck in limbo 😊Anyways I'm mostly opening this issue as a reminder and to let you know the RFC has landed, and since I didn't see an issue about it already. Let me know if you need help implementing it.
The text was updated successfully, but these errors were encountered: