Island: Add plugin manifests name if title is None in

monkey_exploitation

Author: ilija-lazoroski

monkey/monkey_island/cc/services/reporting/exploitations/monkey_exploitation.py

@@ -63,8 +63,11 @@ def get_exploits_used_on_node(
     exploiter_titles = set()
     for exploit in successful_exploits:
         successful_exploiter_manifest = plugin_exploiter_manifests.get(exploit.exploiter_name)
-        if successful_exploiter_manifest is not None:
-            exploiter_titles.add(successful_exploiter_manifest.title)
+        if successful_exploiter_manifest:
+            if successful_exploiter_manifest.title:
+                exploiter_titles.add(successful_exploiter_manifest.title)
+            else:
+                exploiter_titles.add(successful_exploiter_manifest.name)
 
     #  AgentPluginManifest title is Optional[str], list expects Iterable[str]
     return list(exploiter_titles)  # type: ignore[arg-type]

monkey/tests/unit_tests/monkey_island/cc/services/reporting/exploitations/test_monkey_exploitation.py

@@ -46,6 +46,15 @@
     exploiter_name="MockExploiter",
 )
 
+EVENT_5 = ExploitationEvent(
+    source=AGENT_ID,
+    timestamp=TIMESTAMP,
+    target=IPv4Address(TARGET_IP_STR),
+    success=True,
+    exploiter_name="Mock1Exploiter",
+)
+
+
 MACHINE = Machine(
     id=1,
     hardware_id=101,
@@ -64,7 +73,16 @@
             description="Mocked description",
             link_to_documentation="http://no_mocked.com",
             safe=True,
-        )
+        ),
+        "Mock1Exploiter": AgentPluginManifest(
+            name="Mock1Exploiter",
+            plugin_type=AgentPluginType.EXPLOITER,
+            title=None,
+            target_operating_systems=(OperatingSystem.WINDOWS,),
+            description="Another Mocked description",
+            link_to_documentation="http://nopenope.com",
+            safe=True,
+        ),
     }
 }
 
@@ -99,3 +117,8 @@ def test_get_exploits_used_on_node__mixed_exploits():
 def test_get_exploits_used_on_node__empty_plugin_manifests():
     exploits = get_exploits_used_on_node(MACHINE, [EVENT_1, EVENT_2, EVENT_3], {})
     assert sorted(exploits) == sorted(["SSH Exploiter", "Log4Shell Exploiter"])
+
+
+def test_get_exploits_used_on_node__empty_title():
+    exploits = get_exploits_used_on_node(MACHINE, [EVENT_5], PLUGIN_MANIFESTS)
+    assert sorted(exploits) == sorted(["Mock1Exploiter"])