Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traceroute binaries #1397

Closed
1 task
mssalvatore opened this issue Aug 3, 2021 · 2 comments · Fixed by #1422
Closed
1 task

Remove traceroute binaries #1397

mssalvatore opened this issue Aug 3, 2021 · 2 comments · Fixed by #1422

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Aug 3, 2021

Infection Monkey no longer uses custom-built traceroute binaries, but certain items (deployment scripts, monkey.spec, etc.) have a dependency on them.

Tasks

  • Remove all dependencies on the traceroute binaries. Run blackbox tests. (0.25d) @mssalvatore
@ilija-lazoroski
Copy link
Contributor

ilija-lazoroski commented Aug 18, 2021

List of where we mention traceroute binaries:

deployment_scripts/config
deployment_scripts/deploy_linux.sh
deployment_scripts/config.ps1
monkey/infection_monkey/bin/traceroute32
monkey/infection_monkey/bin/traceroute64
monkey/infection_monkey/monkey.spec
monkey/infection_monkey/readme.md

@mssalvatore
Copy link
Collaborator Author

The jenkins build copies the binaries from the storage machine into a bin/ directory. Since this is also used for the sambacry binaries, no changes are required at this time.

https://github.com/guardicore/labs/blob/c4e0a39abe0d5716076217efff1c7c0b67d11f04/InfectionMonkey/InfectionMonkey/jenkins_script_linux.sh#L21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants