Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid Linux custom PBA filename is invalid on Windows Island. #2119

Closed
mssalvatore opened this issue Jul 26, 2022 · 1 comment
Closed

Valid Linux custom PBA filename is invalid on Windows Island. #2119

mssalvatore opened this issue Jul 26, 2022 · 1 comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Low

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jul 26, 2022

Description

Rules about valid Linux file names are much more permissive than Windows file names. When a custom Linux PBA file is submitted to a Windows Island, the file may not be able to be written to disk if it violates Windows file naming rules.

Proposed solution

Convert PBA file names to base64url

Caveats

Some filenames could potentially resolve to reserved Windows files. For example, 5B encodes to NUL, which is reserved. This could be easily remedied by applying a prefix to all base64url encoded file names.

If possible, let's delay this work until we refactor Custom PBAs as a payload.

Alternative solutions

  1. Only allow Linux custom PBA files to use Windows-safe filenames
  2. Store files in MongoDB instead of on disk
@mssalvatore mssalvatore added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Impact: Low Complexity: Low labels Jul 26, 2022
@cakekoa
Copy link
Contributor

cakekoa commented Oct 25, 2022

PBAs are being removed in #2442

@cakekoa cakekoa closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Low
Projects
None yet
Development

No branches or pull requests

2 participants