Merge pull request #218 from hapijs/buffer

Remove new Buffer usage

Author: hueniverse

README.md

@@ -57,7 +57,7 @@ const wreckWithTimeout = wreck.defaults({
 // all attributes are optional
 const options = {
     baseUrl: 'https://www.example.com',
-    payload: readableStream || 'foo=bar' || new Buffer('foo=bar'),
+    payload: readableStream || 'foo=bar' || Buffer.from('foo=bar'),
     headers: { /* http headers */ },
     redirects: 3,
     beforeRedirect: (redirectMethod, statusCode, location, resHeaders, redirectOptions, next) => next(),
@@ -272,7 +272,7 @@ for the provided payload and encoding.
 <!-- eslint-disable no-unused-vars -->
 <!-- eslint-disable no-undef -->
 ```javascript
-const stream = Wreck.toReadableStream(new Buffer('Hello', 'ascii'), 'ascii');
+const stream = Wreck.toReadableStream(Buffer.from('Hello', 'ascii'), 'ascii');
 const read = stream.read();
 // read -> 'Hello'
 ```

lib/payload.js

@@ -20,7 +20,7 @@ module.exports = internals.Payload = function (payload, encoding) {
     for (let i = 0; i < data.length; ++i) {
         const chunk = data[i];
         size = size + chunk.length;
-        data[i] = Buffer.isBuffer(chunk) ? chunk : new Buffer(chunk);
+        data[i] = Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk);
     }
 
     this._data = Buffer.concat(data, size);

lib/recorder.js

@@ -40,6 +40,6 @@ internals.Recorder.prototype._write = function (chunk, encoding, next) {
 
 internals.Recorder.prototype.collect = function () {
 
-    const buffer = (this.buffers.length === 0 ? new Buffer(0) : (this.buffers.length === 1 ? this.buffers[0] : Buffer.concat(this.buffers, this.length)));
+    const buffer = (this.buffers.length === 0 ? Buffer.alloc(0) : (this.buffers.length === 1 ? this.buffers[0] : Buffer.concat(this.buffers, this.length)));
     return buffer;
 };

test/index.js

@@ -762,7 +762,7 @@ describe('request()', () => {
     it('requests payload in buffer', async () => {
 
         const server = await internals.server('echo');
-        const buf = new Buffer(internals.payload, 'ascii');
+        const buf = Buffer.from(internals.payload, 'ascii');
 
         const res = await Wreck.request('post', 'http://localhost:' + server.address().port, { payload: buf });
         const body = await Wreck.read(res);