Skip to content

Commit 11538d0

Browse files
roopa-prabhudavem330
authored andcommitted
bridge: vlan dst_metadata hooks in ingress and egress paths
- ingress hook: - if port is a tunnel port, use tunnel info in attached dst_metadata to map it to a local vlan - egress hook: - if port is a tunnel port, use tunnel info attached to vlan to set dst_metadata on the skb CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent efa5356 commit 11538d0

File tree

6 files changed

+82
-2
lines changed

6 files changed

+82
-2
lines changed

net/bridge/br_forward.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ static void __br_forward(const struct net_bridge_port *to,
8080
int br_hook;
8181

8282
vg = nbp_vlan_group_rcu(to);
83-
skb = br_handle_vlan(to->br, vg, skb);
83+
skb = br_handle_vlan(to->br, to, vg, skb);
8484
if (!skb)
8585
return;
8686

net/bridge/br_input.c

+7-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include <linux/export.h>
2222
#include <linux/rculist.h>
2323
#include "br_private.h"
24+
#include "br_private_tunnel.h"
2425

2526
/* Hook for brouter */
2627
br_should_route_hook_t __rcu *br_should_route_hook __read_mostly;
@@ -57,7 +58,7 @@ static int br_pass_frame_up(struct sk_buff *skb)
5758

5859
indev = skb->dev;
5960
skb->dev = brdev;
60-
skb = br_handle_vlan(br, vg, skb);
61+
skb = br_handle_vlan(br, NULL, vg, skb);
6162
if (!skb)
6263
return NET_RX_DROP;
6364
/* update the multicast stats if the packet is IGMP/MLD */
@@ -261,6 +262,11 @@ rx_handler_result_t br_handle_frame(struct sk_buff **pskb)
261262
return RX_HANDLER_CONSUMED;
262263

263264
p = br_port_get_rcu(skb->dev);
265+
if (p->flags & BR_VLAN_TUNNEL) {
266+
if (br_handle_ingress_vlan_tunnel(skb, p,
267+
nbp_vlan_group_rcu(p)))
268+
goto drop;
269+
}
264270

265271
if (unlikely(is_link_local_ether_addr(dest))) {
266272
u16 fwd_mask = p->br->group_fwd_mask_required;

net/bridge/br_private.h

+2
Original file line numberDiff line numberDiff line change
@@ -775,6 +775,7 @@ bool br_allowed_egress(struct net_bridge_vlan_group *vg,
775775
const struct sk_buff *skb);
776776
bool br_should_learn(struct net_bridge_port *p, struct sk_buff *skb, u16 *vid);
777777
struct sk_buff *br_handle_vlan(struct net_bridge *br,
778+
const struct net_bridge_port *port,
778779
struct net_bridge_vlan_group *vg,
779780
struct sk_buff *skb);
780781
int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags);
@@ -874,6 +875,7 @@ static inline bool br_should_learn(struct net_bridge_port *p,
874875
}
875876

876877
static inline struct sk_buff *br_handle_vlan(struct net_bridge *br,
878+
const struct net_bridge_port *port,
877879
struct net_bridge_vlan_group *vg,
878880
struct sk_buff *skb)
879881
{

net/bridge/br_private_tunnel.h

+11
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ int nbp_vlan_tunnel_info_add(struct net_bridge_port *port, u16 vid, u32 tun_id);
4040
void nbp_vlan_tunnel_info_flush(struct net_bridge_port *port);
4141
void vlan_tunnel_info_del(struct net_bridge_vlan_group *vg,
4242
struct net_bridge_vlan *vlan);
43+
int br_handle_ingress_vlan_tunnel(struct sk_buff *skb,
44+
struct net_bridge_port *p,
45+
struct net_bridge_vlan_group *vg);
46+
int br_handle_egress_vlan_tunnel(struct sk_buff *skb,
47+
struct net_bridge_vlan *vlan);
4348
#else
4449
static inline int vlan_tunnel_init(struct net_bridge_vlan_group *vg)
4550
{
@@ -67,6 +72,12 @@ static inline void vlan_tunnel_info_del(struct net_bridge_vlan_group *vg,
6772
{
6873
}
6974

75+
static inline int br_handle_ingress_vlan_tunnel(struct sk_buff *skb,
76+
struct net_bridge_port *p,
77+
struct net_bridge_vlan_group *vg)
78+
{
79+
return 0;
80+
}
7081
#endif
7182

7283
#endif

net/bridge/br_vlan.c

+7
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,7 @@ static void __vlan_flush(struct net_bridge_vlan_group *vg)
341341
}
342342

343343
struct sk_buff *br_handle_vlan(struct net_bridge *br,
344+
const struct net_bridge_port *p,
344345
struct net_bridge_vlan_group *vg,
345346
struct sk_buff *skb)
346347
{
@@ -381,6 +382,12 @@ struct sk_buff *br_handle_vlan(struct net_bridge *br,
381382

382383
if (v->flags & BRIDGE_VLAN_INFO_UNTAGGED)
383384
skb->vlan_tci = 0;
385+
386+
if (p && (p->flags & BR_VLAN_TUNNEL) &&
387+
br_handle_egress_vlan_tunnel(skb, v)) {
388+
kfree_skb(skb);
389+
return NULL;
390+
}
384391
out:
385392
return skb;
386393
}

net/bridge/br_vlan_tunnel.c

+54
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,13 @@ static const struct rhashtable_params br_vlan_tunnel_rht_params = {
3939
.automatic_shrinking = true,
4040
};
4141

42+
static struct net_bridge_vlan *br_vlan_tunnel_lookup(struct rhashtable *tbl,
43+
u64 tunnel_id)
44+
{
45+
return rhashtable_lookup_fast(tbl, &tunnel_id,
46+
br_vlan_tunnel_rht_params);
47+
}
48+
4249
void vlan_tunnel_info_del(struct net_bridge_vlan_group *vg,
4350
struct net_bridge_vlan *vlan)
4451
{
@@ -147,3 +154,50 @@ void vlan_tunnel_deinit(struct net_bridge_vlan_group *vg)
147154
{
148155
rhashtable_destroy(&vg->tunnel_hash);
149156
}
157+
158+
int br_handle_ingress_vlan_tunnel(struct sk_buff *skb,
159+
struct net_bridge_port *p,
160+
struct net_bridge_vlan_group *vg)
161+
{
162+
struct ip_tunnel_info *tinfo = skb_tunnel_info(skb);
163+
struct net_bridge_vlan *vlan;
164+
165+
if (!vg || !tinfo)
166+
return 0;
167+
168+
/* if already tagged, ignore */
169+
if (skb_vlan_tagged(skb))
170+
return 0;
171+
172+
/* lookup vid, given tunnel id */
173+
vlan = br_vlan_tunnel_lookup(&vg->tunnel_hash, tinfo->key.tun_id);
174+
if (!vlan)
175+
return 0;
176+
177+
skb_dst_drop(skb);
178+
179+
__vlan_hwaccel_put_tag(skb, p->br->vlan_proto, vlan->vid);
180+
181+
return 0;
182+
}
183+
184+
int br_handle_egress_vlan_tunnel(struct sk_buff *skb,
185+
struct net_bridge_vlan *vlan)
186+
{
187+
int err;
188+
189+
if (!vlan || !vlan->tinfo.tunnel_id)
190+
return 0;
191+
192+
if (unlikely(!skb_vlan_tag_present(skb)))
193+
return 0;
194+
195+
skb_dst_drop(skb);
196+
err = skb_vlan_pop(skb);
197+
if (err)
198+
return err;
199+
200+
skb_dst_set(skb, dst_clone(&vlan->tinfo.tunnel_dst->dst));
201+
202+
return 0;
203+
}

0 commit comments

Comments
 (0)