ALSA: rme32.c irq enabling after spin_lock_irq

evdenis · tiwai · commit f49a59c4471d · 2013-02-11T16:12:24.000+01:00
According to the other code in this driver and similar
code in rme96 it seems, that spin_lock_irq in
snd_rme32_capture_close function should be paired
with spin_unlock_irq.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov &lt;yefremov.denis@gmail.com&gt;
Cc: &lt;stable@vger.kernel.org&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
@@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)
 	spin_lock_irq(&rme32->lock);
 	rme32->capture_substream = NULL;
 	rme32->capture_periodsize = 0;
-	spin_unlock(&rme32->lock);
+	spin_unlock_irq(&rme32->lock);
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)`
`1017`	`1017`	`spin_lock_irq(&rme32->lock);`
`1018`	`1018`	`rme32->capture_substream = NULL;`
`1019`	`1019`	`rme32->capture_periodsize = 0;`
`1020`		`- spin_unlock(&rme32->lock);`
	`1020`	`+ spin_unlock_irq(&rme32->lock);`
`1021`	`1021`	`return 0;`
`1022`	`1022`	`}`
`1023`	`1023`