target main.tf in module if file exists

Author: dbanck

schema/module_schema.go

@@ -94,6 +94,10 @@ func schemaForDependentModuleBlock(localName string, modMeta *module.Meta) (*sch
 	if len(modMeta.Files) > 0 {
 		filename := modMeta.Files[0]
 
+		if sliceContains(modMeta.Files, "main.tf") {
+			filename = "main.tf"
+		}
+
 		bodySchema.Targets = &schema.Target{
 			Path: lang.Path{
 				Path:       modMeta.Path,
@@ -109,3 +113,12 @@ func schemaForDependentModuleBlock(localName string, modMeta *module.Meta) (*sch
 
 	return bodySchema, nil
 }
+
+func sliceContains(slice []string, value string) bool {
+	for _, val := range slice {
+		if val == value {
+			return true
+		}
+	}
+	return false
+}

schema/module_schema_test.go

@@ -6,6 +6,7 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/hashicorp/hcl-lang/lang"
 	"github.com/hashicorp/hcl-lang/schema"
+	"github.com/hashicorp/hcl/v2"
 	"github.com/hashicorp/terraform-schema/internal/schema/refscope"
 	"github.com/hashicorp/terraform-schema/module"
 	"github.com/zclconf/go-cty-debug/ctydebug"
@@ -166,3 +167,86 @@ func TestSchemaForDependentModuleBlock_basic(t *testing.T) {
 		t.Fatalf("schema mismatch: %s", diff)
 	}
 }
+
+func TestSchemaForDependentModuleBlock_Target(t *testing.T) {
+	type testCase struct {
+		name           string
+		meta           *module.Meta
+		expectedSchema *schema.BodySchema
+	}
+
+	testCases := []testCase{
+		{
+			"without main.tf",
+			&module.Meta{
+				Path:      "./local",
+				Variables: map[string]module.Variable{},
+				Outputs:   map[string]module.Output{},
+				Files:     []string{"a_file.tf", "b_file.tf"},
+			},
+			&schema.BodySchema{
+				Attributes: map[string]*schema.AttributeSchema{},
+				TargetableAs: []*schema.Targetable{
+					{
+						Address: lang.Address{
+							lang.RootStep{Name: "module"},
+							lang.AttrStep{Name: "refname"},
+						},
+						ScopeId:           refscope.ModuleScope,
+						AsType:            cty.Object(map[string]cty.Type{}),
+						NestedTargetables: []*schema.Targetable{},
+					},
+				},
+				Targets: &schema.Target{
+					Path: lang.Path{Path: "./local", LanguageID: "terraform"},
+					Range: hcl.Range{
+						Filename: "a_file.tf",
+						Start:    hcl.InitialPos,
+						End:      hcl.InitialPos,
+					},
+				},
+			},
+		},
+		{
+			"with main.tf",
+			&module.Meta{
+				Path:      "./local",
+				Variables: map[string]module.Variable{},
+				Outputs:   map[string]module.Output{},
+				Files:     []string{"a_file.tf", "main.tf"},
+			},
+			&schema.BodySchema{
+				Attributes: map[string]*schema.AttributeSchema{},
+				TargetableAs: []*schema.Targetable{
+					{
+						Address: lang.Address{
+							lang.RootStep{Name: "module"},
+							lang.AttrStep{Name: "refname"},
+						},
+						ScopeId:           refscope.ModuleScope,
+						AsType:            cty.Object(map[string]cty.Type{}),
+						NestedTargetables: []*schema.Targetable{},
+					},
+				},
+				Targets: &schema.Target{
+					Path: lang.Path{Path: "./local", LanguageID: "terraform"},
+					Range: hcl.Range{
+						Filename: "main.tf",
+						Start:    hcl.InitialPos,
+						End:      hcl.InitialPos,
+					},
+				},
+			},
+		},
+	}
+
+	for _, tc := range testCases {
+		depSchema, err := schemaForDependentModuleBlock("refname", tc.meta)
+		if err != nil {
+			t.Fatal(err)
+		}
+		if diff := cmp.Diff(tc.expectedSchema, depSchema, ctydebug.CmpOptions); diff != "" {
+			t.Fatalf("schema mismatch: %s", diff)
+		}
+	}
+}