You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of v8.0.0 the vscode-languageclient library has put significant work into stabilizing and cleaning up the LanguageClient API.
Most relevant to us immediately is the cleanup of the start and stop methods which resulted in the collapsing the start and onReady methods to one single start method. This will reduce the number of places we need to track error handling (the varying places we activate) and whether or not the LS is "ready" yet before requesting a command (terraform-ls commands like Module View bar).
Also of note is a change to how ErrorHandler functions, which allows us to return a message to the user when the extension fails to activate. This should help with situations like #1301 by helping us produce more exact and timely error messages.
This requires us to bump the minimum engine version from 1.65.2 to 1.67.0. Looking back at the last 30 days of usage, over 90% of our users are on 1.70 or newer so this should not be a disruptive update.
Proposal
Bump the minimum engine version from 1.65.2 to 1.67.0
Update to v8.0.2 of vscode-languageclient
The text was updated successfully, but these errors were encountered:
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Background
As of v8.0.0 the vscode-languageclient library has put significant work into stabilizing and cleaning up the LanguageClient API.
Most relevant to us immediately is the cleanup of the start and stop methods which resulted in the collapsing the
start
andonReady
methods to one singlestart
method. This will reduce the number of places we need to track error handling (the varying places we activate) and whether or not the LS is "ready" yet before requesting a command (terraform-ls commands like Module View bar).Also of note is a change to how ErrorHandler functions, which allows us to return a message to the user when the extension fails to activate. This should help with situations like #1301 by helping us produce more exact and timely error messages.
This requires us to bump the minimum engine version from 1.65.2 to 1.67.0. Looking back at the last 30 days of usage, over 90% of our users are on 1.70 or newer so this should not be a disruptive update.
Proposal
vscode-languageclient
The text was updated successfully, but these errors were encountered: