Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of deprecated 'Role' type #12

Open
2 tasks
haypho opened this issue Jul 28, 2023 · 0 comments
Open
2 tasks

Remove use of deprecated 'Role' type #12

haypho opened this issue Jul 28, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers high priority

Comments

@haypho
Copy link
Owner

haypho commented Jul 28, 2023

Previously the 'Role' type was introduced as an enum, however, it has recently been deprecated in favor of using the string type. This way we can dynamically pull roles from the data on nightly deploys even though we have not updated the website to support those types.

  • Remove the deprecated 'Role' type
  • Convert the RoleFilter component to use a dynamic list of roles derived from the list of gods
@haypho haypho added enhancement New feature or request good first issue Good for newcomers high priority labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haypho