Skip to content

Commit 620ba3d

Browse files
committed
benchmarks: fix bench_scalar_split
scalar_split_lambda requires that the input pointer is different to both output pointers. Without this fix, the internal benchmarks crash when compiled with -DVERIFY. This was introduced in commit 362bb25 (which requires configuring with --enable-endomorphism to exhibit the crash).
1 parent 5fbff5d commit 620ba3d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/bench_internal.c

+3-2
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,11 @@ static void bench_scalar_mul(void* arg, int iters) {
110110
static void bench_scalar_split(void* arg, int iters) {
111111
int i, j = 0;
112112
bench_inv *data = (bench_inv*)arg;
113+
secp256k1_scalar tmp;
113114

114115
for (i = 0; i < iters; i++) {
115-
secp256k1_scalar_split_lambda(&data->scalar[0], &data->scalar[1], &data->scalar[0]);
116-
j += secp256k1_scalar_add(&data->scalar[0], &data->scalar[0], &data->scalar[1]);
116+
secp256k1_scalar_split_lambda(&tmp, &data->scalar[1], &data->scalar[0]);
117+
j += secp256k1_scalar_add(&data->scalar[0], &tmp, &data->scalar[1]);
117118
}
118119
CHECK(j <= iters);
119120
}

0 commit comments

Comments
 (0)