Skip to content

Commit dda0770

Browse files
authored
bump kind to v0.20.0 and script cleanup (#88)
Signed-off-by: cpanato <ctadeu@gmail.com>
1 parent a2c862b commit dda0770

File tree

4 files changed

+35
-35
lines changed

4 files changed

+35
-35
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ For more information, reference the GitHub Help Documentation for [Creating a wo
1515

1616
For more information on inputs, see the [API Documentation](https://developer.github.com/v3/repos/releases/#input)
1717

18-
- `version`: The kind version to use (default: `v0.19.0`)
18+
- `version`: The kind version to use (default: `v0.20.0`)
1919
- `config`: The path to the kind config file
2020
- `node_image`: The Docker image for the cluster nodes
2121
- `cluster_name`: The name of the cluster to create (default: `chart-testing`)
@@ -39,7 +39,7 @@ jobs:
3939
runs-on: ubuntu-latest
4040
steps:
4141
- name: Create k8s Kind Cluster
42-
uses: helm/kind-action@v1.4.0
42+
uses: helm/kind-action@v1.5.0
4343
```
4444
4545
This uses [@helm/kind-action](https://www.github.com/helm/kind-action) GitHub Action to spin up a [kind](https://kind.sigs.k8s.io/) Kubernetes cluster on every Pull Request.

action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ inputs:
88
version:
99
description: "The kind version to use (default: v0.19.0)"
1010
required: false
11-
default: "v0.19.0"
11+
default: "v0.20.0"
1212
config:
1313
description: "The path to the kind config file"
1414
required: false

kind.sh

+31-31
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ set -o errexit
1818
set -o nounset
1919
set -o pipefail
2020

21-
DEFAULT_KIND_VERSION=v0.19.0
21+
DEFAULT_KIND_VERSION=v0.20.0
2222
DEFAULT_CLUSTER_NAME=chart-testing
23-
DEFAULT_KUBECTL_VERSION=v1.26.4
23+
DEFAULT_KUBECTL_VERSION=v1.26.6
2424

2525
show_help() {
2626
cat << EOF
@@ -40,19 +40,19 @@ EOF
4040
}
4141

4242
main() {
43-
local version="$DEFAULT_KIND_VERSION"
43+
local version="${DEFAULT_KIND_VERSION}"
4444
local config=
4545
local node_image=
46-
local cluster_name="$DEFAULT_CLUSTER_NAME"
46+
local cluster_name="${DEFAULT_CLUSTER_NAME}"
4747
local wait=60s
4848
local verbosity=
49-
local kubectl_version="$DEFAULT_KUBECTL_VERSION"
49+
local kubectl_version="${DEFAULT_KUBECTL_VERSION}"
5050
local install_only=false
5151

5252
parse_command_line "$@"
5353

54-
if [[ ! -d "$RUNNER_TOOL_CACHE" ]]; then
55-
echo "Cache directory '$RUNNER_TOOL_CACHE' does not exist" >&2
54+
if [[ ! -d "${RUNNER_TOOL_CACHE}" ]]; then
55+
echo "Cache directory '${RUNNER_TOOL_CACHE}' does not exist" >&2
5656
exit 1
5757
fi
5858

@@ -63,28 +63,28 @@ main() {
6363
x86_64) arch="amd64" ;;
6464
arm|aarch64) dpkg --print-architecture | grep -q "arm64" && arch="arm64" || arch="arm" ;;
6565
esac
66-
local cache_dir="$RUNNER_TOOL_CACHE/kind/$version/$arch"
66+
local cache_dir="${RUNNER_TOOL_CACHE}/kind/${version}/${arch}"
6767

68-
local kind_dir="$cache_dir/kind/bin/"
69-
if [[ ! -x "$kind_dir/kind" ]]; then
68+
local kind_dir="${cache_dir}/kind/bin/"
69+
if [[ ! -x "${kind_dir}/kind" ]]; then
7070
install_kind
7171
fi
7272

7373
echo 'Adding kind directory to PATH...'
74-
echo "$kind_dir" >> "$GITHUB_PATH"
74+
echo "${kind_dir}" >> "${GITHUB_PATH}"
7575

76-
local kubectl_dir="$cache_dir/kubectl/bin/"
77-
if [[ ! -x "$kubectl_dir/kubectl" ]]; then
76+
local kubectl_dir="${cache_dir}/kubectl/bin/"
77+
if [[ ! -x "${kubectl_dir}/kubectl" ]]; then
7878
install_kubectl
7979
fi
8080

8181
echo 'Adding kubectl directory to PATH...'
82-
echo "$kubectl_dir" >> "$GITHUB_PATH"
82+
echo "${kubectl_dir}" >> "${GITHUB_PATH}"
8383

84-
"$kind_dir/kind" version
85-
"$kubectl_dir/kubectl" version --client=true
84+
"${kind_dir}/kind" version
85+
"${kubectl_dir}/kubectl" version --client=true
8686

87-
if [[ "$install_only" == false ]]; then
87+
if [[ "${install_only}" == false ]]; then
8888
create_kind_cluster
8989
fi
9090
}
@@ -186,38 +186,38 @@ parse_command_line() {
186186
install_kind() {
187187
echo 'Installing kind...'
188188

189-
mkdir -p "$kind_dir"
189+
mkdir -p "${kind_dir}"
190190

191-
curl -sSLo "$kind_dir/kind" "https://github.com/kubernetes-sigs/kind/releases/download/$version/kind-linux-$arch"
192-
chmod +x "$kind_dir/kind"
191+
curl -sSLo "${kind_dir}/kind" "https://github.com/kubernetes-sigs/kind/releases/download/${version}/kind-linux-${arch}"
192+
chmod +x "${kind_dir}/kind"
193193
}
194194

195195
install_kubectl() {
196196
echo 'Installing kubectl...'
197197

198-
mkdir -p "$kubectl_dir"
198+
mkdir -p "${kubectl_dir}"
199199

200-
curl -sSLo "$kubectl_dir/kubectl" "https://storage.googleapis.com/kubernetes-release/release/$kubectl_version/bin/linux/$arch/kubectl"
201-
chmod +x "$kubectl_dir/kubectl"
200+
curl -sSLo "${kubectl_dir}/kubectl" "https://storage.googleapis.com/kubernetes-release/release/${kubectl_version}/bin/linux/${arch}/kubectl"
201+
chmod +x "${kubectl_dir}/kubectl"
202202
}
203203

204204
create_kind_cluster() {
205205
echo 'Creating kind cluster...'
206-
local args=(create cluster "--name=$cluster_name" "--wait=$wait")
206+
local args=(create cluster "--name=${cluster_name}" "--wait=${wait}")
207207

208-
if [[ -n "$node_image" ]]; then
209-
args+=("--image=$node_image")
208+
if [[ -n "${node_image}" ]]; then
209+
args+=("--image=${node_image}")
210210
fi
211211

212-
if [[ -n "$config" ]]; then
213-
args+=("--config=$config")
212+
if [[ -n "${config}" ]]; then
213+
args+=("--config=${config}")
214214
fi
215215

216-
if [[ -n "$verbosity" ]]; then
217-
args+=("--verbosity=$verbosity")
216+
if [[ -n "${verbosity}" ]]; then
217+
args+=("--verbosity=${verbosity}")
218218
fi
219219

220-
"$kind_dir/kind" "${args[@]}"
220+
"${kind_dir}/kind" "${args[@]}"
221221
}
222222

223223
main "$@"

main.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ main() {
5555
args+=(--install-only)
5656
fi
5757

58-
"$SCRIPT_DIR/kind.sh" ${args[@]+"${args[@]}"}
58+
"${SCRIPT_DIR}/kind.sh" ${args[@]+"${args[@]}"}
5959
}
6060

6161
main

0 commit comments

Comments
 (0)