-
Notifications
You must be signed in to change notification settings - Fork 78
Windows 10 Blank Status Line #75
Comments
Yeah, status line is not working on wsl yet |
What kind of work would this need to get it working under WSL? |
I've been trying to get this plugin working with WSL and it's not as easy as I though. Let me walk you through my thought process, what I've achieved already and the problems with my approach. For all this to work there's a bunch of things that need to happen only if the active shell is a WSL. My approach to know that is simple, as long as vercel/hyper#3046 is merged. We start with this: Now, for WSL we cannot rely on Node's And that's our first problem, Interop between Windows and WSL, which is a bit slow. We're spwaning a new command with Given the change above we are now going to run all our commands inside WSL, meaning the PID used by Here I have to run Now we need to handle all the Git commands that are executed through the whole plugin. The problem with those when running WSL is that although they still run with So, before running However, it's quite slow because for each Even if this was fast enough, the work to get
There's also a problem with the home folder, which should be replaced with The last thing that I remember that is missing to fix all WSL issues is opening Windows Explorer in the correct path when clicking the status line path element. Everyone feel free to pitch with suggestions and improvements so we can get WSL support into |
I've made a small improvement to the implementation above: Instead of getting converting a WSL path to a Windows path multiple times (per each Git command invocation, basically), now it's converted only once before invoking the This improves performance a bit but not enough... This can easily be tested by launching Hyper and as soon as WSL is ready, just press Return a bunch of times in succession. Look at the task manager and you'll see the Electron process eating all the CPU with too many Oh, well... |
Made two small improvements and fixed a new found issue at the same time: Forced WSL bash commands to run in non-interactive mode, speeding up all commands a bit. Instead of passing the current working directory to This is still too slow because for every command typed into the Hyper terminal, a lot of |
I think perhaps we should run a helper inside of WSL that broadcasts on an e.g. Unix Socket. Windows can read the Unix Socket file to get the latest information and then draw it that way. |
It looks like it half works now. its dumping errors to the status bar line, but not git info. Is this being actively looked into or has it been determined to be too difficult? |
@rfgamaral : any updates on this thread/PR? |
I'm no longer working on it, I couldn't find a reliable solution. |
I am using hyper with WSL on Windows 10. All I see an empty status bar
The text was updated successfully, but these errors were encountered: