chore: demo late discovery

hi-ogawa · hi-ogawa · commit c6550579e36b · 2024-10-21T16:23:07.000+09:00
diff --git a/playground/environment-react-ssr/deps/test-dep/index.mjs b/playground/environment-react-ssr/deps/test-dep/index.mjs
@@ -0,0 +1 @@
+export default { id: Math.random().toString(36).slice(2) }
diff --git a/playground/environment-react-ssr/deps/test-dep/other.mjs b/playground/environment-react-ssr/deps/test-dep/other.mjs
@@ -0,0 +1 @@
+export { default } from './index.mjs'
diff --git a/playground/environment-react-ssr/deps/test-dep/package.json b/playground/environment-react-ssr/deps/test-dep/package.json
@@ -0,0 +1,9 @@
+{
+  "name": "@vitejs/test-dep",
+  "private": true,
+  "type": "module",
+  "exports": {
+    ".": "./index.mjs",
+    "./other": "./other.mjs"
+  }
+}
diff --git a/playground/environment-react-ssr/package.json b/playground/environment-react-ssr/package.json
@@ -4,13 +4,14 @@
   "version": "0.0.0",
   "type": "module",
   "scripts": {
-    "dev": "vite --force",
+    "dev": "vite",
     "build": "vite build --app",
     "preview": "vite preview"
   },
   "devDependencies": {
     "@types/react": "^18.3.11",
     "@types/react-dom": "^18.3.0",
+    "@vitejs/test-dep": "file:./deps/test-dep",
     "react": "^18.3.1",
     "react-fake-client": "npm:react@^18.3.1",
     "react-fake-server": "npm:react@^18.3.1",
diff --git a/playground/environment-react-ssr/src/entry-server.tsx b/playground/environment-react-ssr/src/entry-server.tsx
@@ -1,8 +1,25 @@
 import ReactDomServer from 'react-dom/server'
 import type { Connect, ViteDevServer } from 'vite'
+import testDep from '@vitejs/test-dep'
 import Root from './root'
 
 const handler: Connect.NextHandleFunction = async (_req, res) => {
+  const url = new URL(_req.url!, 'http://localhost')
+  if (url.pathname === '/late-discovery') {
+    // simulate late discovery by importing new modules from virtual.
+    // this can cuase double modules on first request handling and
+    // response would look like
+    //   {"entry":{"id":"heyzuawcitr"},"late":{"id":"autz5sutu1k"}}
+    // @ts-expect-error no dts
+    const mod = await import('virtual:late-discovery')
+    res.setHeader('content-type', 'application/json').end(
+      JSON.stringify({
+        entry: testDep,
+        late: mod.default,
+      }),
+    )
+    return
+  }
   const ssrHtml = ReactDomServer.renderToString(<Root />)
   let html = await importHtml()
   html = html.replace(/<body>/, `<body><div id="root">${ssrHtml}</div>`)
diff --git a/playground/environment-react-ssr/vite.config.ts b/playground/environment-react-ssr/vite.config.ts
@@ -20,9 +20,27 @@ export default defineConfig((env) => ({
         Object.assign(globalThis, { __globalServer: server })
       },
     },
+    {
+      name: 'virtual-late-discovery',
+      resolveId(source) {
+        if (source === 'virtual:late-discovery') {
+          return '\0' + source
+        }
+      },
+      load(id) {
+        if (id === '\0virtual:late-discovery') {
+          return `export { default } from "@vitejs/test-dep/other"`
+        }
+      },
+    },
   ],
   environments: {
     client: {
+      dev: {
+        optimizeDeps: {
+          include: ['react/jsx-dev-runtime'],
+        },
+      },
       build: {
         minify: false,
         sourcemap: true,
@@ -33,6 +51,7 @@ export default defineConfig((env) => ({
       dev: {
         optimizeDeps: {
           noDiscovery: false,
+          include: ['react/jsx-dev-runtime'],
         },
       },
       build: {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export default { id: Math.random().toString(36).slice(2) }`