Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to faststart oracle image for testing #1383

Closed
blafond opened this issue Aug 31, 2022 · 2 comments
Closed

Switch to faststart oracle image for testing #1383

blafond opened this issue Aug 31, 2022 · 2 comments
Assignees
Labels
testing Improvements to test suite

Comments

@blafond
Copy link
Member

blafond commented Aug 31, 2022

Quarkus has made the switch to improve bootstrapping. See this PR for details

<oracle.image>docker.io/gvenzl/oracle-xe:21-slim</oracle.image>

@blafond blafond self-assigned this Aug 31, 2022
@blafond
Copy link
Member Author

blafond commented Aug 31, 2022

@DavideD Ran clean build locally multiple times with both oracle versions I get basically the same results for either one. ~2 minutes.

Are there more specific metrics or ways I could track?

@DavideD
Copy link
Member

DavideD commented Sep 1, 2022

That's fine, I was expecting something similar because we only start the server once.

I've tried it on my machine:

gvenzl/oracle-xe:21.3.0-slim 
-- with image download:  BUILD SUCCESSFUL in 4m 14s
-- already downloaded :  BUILD SUCCESSFUL in 1m 27s

gvenzl/oracle-xe:21.3.0-faststart
-- with image download: BUILD SUCCESSFUL in 7m 41s 
-- already downloaded : BUILD SUCCESSFUL in 1m 15s 

The build was slightly faster when the image is available but downloading the new image was quite slow.
Not that this is a rigorous indication but I think we can continue to use the slim version for now.

Maybe there's a difference when running it on slower machines. We can reconsider this later.

Thanks

@DavideD DavideD closed this as completed Sep 1, 2022
@DavideD DavideD changed the title Investigate switching to Oracle DB container image: 21-slim-faststart flavour Switch to faststart oracle image for testing Sep 1, 2022
@DavideD DavideD added the testing Improvements to test suite label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements to test suite
Projects
None yet
Development

No branches or pull requests

2 participants