Update persistAll method to return list of roles

The persistAll method in RoleService.java has been revised to return a list of Role objects after saving them. This change is also reflected in FENCEAuthenticationService.java where the returned list of new roles is now properly assigned to newRoles.

Author: Gcolon021

pic-sure-auth-services/src/main/java/edu/harvard/hms/dbmi/avillach/auth/service/impl/RoleService.java

@@ -120,8 +120,8 @@ public Set<Role> getRolesByIds(Set<UUID> roleUuids) {
         return this.roleRepository.findByUuidIn(roleUuids);
     }
 
-    public void persistAll(List<Role> newRoles) {
-        this.roleRepository.saveAll(newRoles);
+    public List<Role> persistAll(List<Role> newRoles) {
+        return this.roleRepository.saveAll(newRoles);
     }
 
     public void persistAll(Set<Role> newRoles) {

pic-sure-auth-services/src/main/java/edu/harvard/hms/dbmi/avillach/auth/service/impl/authentication/FENCEAuthenticationService.java

@@ -271,7 +271,7 @@ public HashMap<String, String> getFENCEProfile(String callback_url, Map<String,
                 .collect(Collectors.toList());
 
         if (!newRoles.isEmpty()) {
-            roleService.persistAll(newRoles);
+            newRoles = roleService.persistAll(newRoles);
             current_user.getRoles().addAll(newRoles);
         }