Use Instant.now() instead of new Date().toInstant().

Replaced `new Date().toInstant()` with `Instant.now()` for clearer and more concise timestamp generation. This simplifies the code and eliminates unnecessary intermediate objects while maintaining the same functionality. Updated corresponding test cases to reflect the changes.

Author: Gcolon021

pic-sure-auth-services/src/main/java/edu/harvard/hms/dbmi/avillach/auth/service/impl/RASPassPortService.java

@@ -20,6 +20,7 @@
 import org.springframework.util.LinkedMultiValueMap;
 import org.springframework.util.MultiValueMap;
 
+import java.time.Instant;
 import java.util.*;
 import java.util.stream.Collectors;
 
@@ -165,7 +166,7 @@ public Set<RasDbgapPermission> ga4gpPassportToRasDbgapPermissions(Set<Optional<G
 
         logger.debug("Converting ga4ghPassports to RasDbgapPermissions");
         HashSet<RasDbgapPermission> rasDbgapPermissions = new HashSet<>();
-        long date = new Date().toInstant().toEpochMilli();
+        long date = Instant.now().toEpochMilli();
         ga4ghPassports.forEach(ga4ghPassport -> {
             if (ga4ghPassport.isPresent()) {
                 Ga4ghPassportV1 ga4ghPassportV1 = ga4ghPassport.get();

pic-sure-auth-services/src/test/java/edu/harvard/hms/dbmi/avillach/auth/service/impl/RASPassPortServiceTest.java

@@ -14,6 +14,7 @@
 import org.springframework.http.ResponseEntity;
 import org.springframework.test.context.ContextConfiguration;
 
+import java.time.Instant;
 import java.util.*;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.stream.Collectors;
@@ -67,7 +68,7 @@ public void testGa4gpPassportStudies_IsNotNull_And_ExpiredPermissionsExcluded()
     @Test
     public void testGa4gpPassportStudies_HasCorrectStudies() {
         Optional<Passport> passport = JWTUtil.parsePassportJWTV11(exampleRasPassport);
-        long futureDate = new Date().toInstant().toEpochMilli() + 100000;
+        long futureDate = Instant.now().toEpochMilli() + 100000;
 
         // Update the expiry date of each permission in our test passport. All permissions in the example passport
         // expired in 2022.
@@ -93,8 +94,8 @@ public void testGa4gpPassportStudies_HasCorrectStudies() {
     @Test
     public void testGa4gpPassportStudies_HalfAreExpired() {
         Optional<Passport> passport = JWTUtil.parsePassportJWTV11(exampleRasPassport);
-        long futureDate = new Date().toInstant().toEpochMilli() + 100000;
-        long pastDate = new Date().toInstant().toEpochMilli() - 100000;
+        long futureDate = Instant.now().toEpochMilli() + 100000;
+        long pastDate = Instant.now().toEpochMilli() - 100000;
 
         List<String> expiredPHS = new ArrayList<>();
         List<String> validPHS = new ArrayList<>();