Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honeybadger.Backtrace.format_line Pattern Matching Breaks With Newer Versions of OTP #415

Closed
tres opened this issue Feb 3, 2022 · 1 comment

Comments

@tres
Copy link

tres commented Feb 3, 2022

Hey my Honeybadger Homies!

Long time listener, first time caller.

So I upgraded one of my projects to 1.13.2 & OTP 24 yesterday & now I'm seeing some unhappiness from Honeybadger when it tries to parse the Elixir stacktrace.

Looks like there was some new meta info added to the stacktrace here: https://github.com/elixir-lang/elixir/pull/10977/files#diff-43a76a6112c9082ee3ddb63acc2419db8764edd039cb52e29e436734b414574bR1971

And I believe that's causing our format_line function pattern matching to miss:

https://github.com/honeybadger-io/honeybadger-elixir/blob/master/lib/honeybadger/backtrace.ex#L27

Normally, I'd just open up a PR with something like:

  defp format_line({mod, fun, args, stack_line}) do
    line = stack_line[:line]
    file = stack_line[:file]
    format_line({mod, fun, args, [file: file, line: line]})
  end

However, I see that there are open issues where my Honeybadger friends are wanting more infos about the error (#336) and just throwing away this info may not be the right move.

So, I'm going to report this here and see what you guys think.

Thanks for all your awesome!

@tres tres changed the title Honeybadger.Backtrace.format_line Pattern Matching Breaks With Newer Versions of Elixir Honeybadger.Backtrace.format_line Pattern Matching Breaks With Newer Versions of OTP Feb 3, 2022
@tres
Copy link
Author

tres commented Feb 3, 2022

derp....

looks like this is actually already fixed here #369

It would seem that I'm locked on a previous version & need to update.

apologies for the noise!

@tres tres closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant