Skip to content

Latest commit

 

History

History
194 lines (154 loc) · 5.63 KB

DEV.org

File metadata and controls

194 lines (154 loc) · 5.63 KB

Coding conventions

Function naming

  • Functions that return a ggplot object must be named with the panel_ prefix.
  • After that prefix, the function name must match the config option name in the .yaml file.

Function implementation

  • The panel_ functions must return the complete ggplot object. No further editions need to be done outside it.
  • All panel_ functions receive the full data as the first parameter.
  • All the possible configurations (legends, plot layers, metrics, …) of the panel_ functions have to be passed as parameters.
  • Use the data$config values as default values for the parameters.

Util Functions

Check package

devtools::check(".")

Test Units

devtools::test()

Style all files

styler::style_dir(".")

Coverage

covr::package_coverage()
c %>% as.tibble() -> t
t %>% filter(filename=="R/phase2.R", value==0) %>% select(functions, first_line, last_line) %>% data.frame()

For manual build

Install:

  • texi2dvi

For travis Run all test

add (test) in the end of your commit message

For Gen data

library(starvz)
pre_phase1 <- starvz_phase1(system.file("extdata", "lu_trace", package = "starvz"), lu_colors, state_filter=2, whichApplication="lu")
starvz_sample_lu <- starvz_read(system.file("extdata", "lu_trace", package = "starvz"), system.file("extdata", "config.yaml", package = "starvz"), selective=FALSE)
usethis::use_data(starvz_sample_lu)

Ideas

Highlight Late Starting Tasks

Description

Use alpha values to highlight late starting tasks, i.e. tasks that have all their dependencies ready but have their execution delayed.

  • We can set a fixed threshold to mark a task as late starting, or we can calculate the alpha value based on the waiting time for each task, considering the max waiting time.

Motivation

This can be useful to highlight critical moments of the application, possibly revealing bad scheduling decisions.

CRAN SUB

Message to CRAN for Submission on 11/02/2022

New Version

  • We updated the package to version 0.7.1 to correct problems warned by Prof. Brian Ripley related to dependencies updates.

Test environments

R CMD check results

Status: 1 NOTE checking installed package size … NOTE installed size is 5.9Mb sub-directories of 1Mb or more: libs 4.8Mb

Message to CRAN for Submission on 05/11/2021

New Version

  • We updated the package to version 0.7.0 to correct problems warned by Prof. Brian Ripley related to rio/car/Rcpp packages.

Test environments

R CMD check results

Status: 1 NOTE checking installed package size … NOTE installed size is 6.1Mb sub-directories of 1Mb or more: libs 4.8Mb

Message to CRAN for Submission on 15/10/2021

New Version

  • Updating the package to version 0.6.0

Test environments

R CMD check results

Status: 1 NOTE checking installed package size … NOTE installed size is 6.1Mb sub-directories of 1Mb or more: libs 4.8Mb

Message to CRAN for Submission on 23/03/2021

New Version

  • Updating the package to version 0.5.0

Test environments

R CMD check results

Status: OK

Message to CRAN for Submission on 25/08/2020

Test environments

R CMD check results

checking CRAN incoming feasibility … NOTE

Maintainer: ‘Lucas Leandro Nesi <lucas.nesi@inf.ufrgs.br>’

New submission

Status: 1 NOTE

This is our first submission.

Message to CRAN for Submission on 27/08/2020

Resubmission

We made all the requested improvements:

  • Improved acronyms in Description
  • Removed almost all \dontrun in examples and used \donttest in examples that take >5s
    • The remaining \dontrun functions (R/atree.R) are for specific data that are not present in the package (large)
  • Removed commented code lines in examples (added the examples instead)
  • Removed all calls of options() and setwd() in extra scripts available in inst/tools

Thank you for all your comments

Test environments

R CMD check results

checking CRAN incoming feasibility … NOTE

Maintainer: ‘Lucas Leandro Nesi <lucas.nesi@inf.ufrgs.br>’

New submission

checking for future file timestamps … NOTE

unable to verify current time

Status: 2 NOTEs

This is a new package. And it seems that http://worldclockapi.com/ is down.