Beacon API: Broadcasting BLS to execution changes should not use the request context in a go routine (prysmaticlabs#15019)

prestonvanloon · web-flow · commit f40b4f16c2c0 · 2025-03-06T15:25:48.000Z
* Broadcasting BLS to execution changes should not use the request context in a go routine

* Changelog fragment
diff --git a/beacon-chain/rpc/eth/beacon/handlers_pool.go b/beacon-chain/rpc/eth/beacon/handlers_pool.go
@@ -633,7 +633,7 @@ func (s *Server) SubmitBLSToExecutionChanges(w http.ResponseWriter, r *http.Requ
 			toBroadcast = append(toBroadcast, sbls)
 		}
 	}
-	go s.broadcastBLSChanges(ctx, toBroadcast)
+	go s.broadcastBLSChanges(context.Background(), toBroadcast)
 	if len(failures) > 0 {
 		failuresErr := &server.IndexedVerificationFailureError{
 			Code:     http.StatusBadRequest,
diff --git a/changelog/pvl_bls-ctx.md b/changelog/pvl_bls-ctx.md
@@ -0,0 +1,3 @@
+### Fixed
+
+- Broadcasting BLS to execution changes should not use the request context in a go routine. Use context.Background() for the broadcasting go routine.

Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,7 @@ func (s Server) SubmitBLSToExecutionChanges(w http.ResponseWriter, r http.Requ`
`633`	`633`	`toBroadcast = append(toBroadcast, sbls)`
`634`	`634`	`}`
`635`	`635`	`}`
`636`		`- go s.broadcastBLSChanges(ctx, toBroadcast)`
	`636`	`+ go s.broadcastBLSChanges(context.Background(), toBroadcast)`
`637`	`637`	`if len(failures) > 0 {`
`638`	`638`	`failuresErr := &server.IndexedVerificationFailureError{`
`639`	`639`	`Code: http.StatusBadRequest,`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+### Fixed`
	`2`	`+`
	`3`	`+- Broadcasting BLS to execution changes should not use the request context in a go routine. Use context.Background() for the broadcasting go routine.`