FAB-10331 Fix mockery mock generation

The comments in the go files which are supposed to generate the mockery
mocks are malformed.  They use:

 // go:generate ...

instead of

 //go:generate

They also assume they are being executed from the root directory, rather
than the current directory.  This CR modifies those statements to
correct those errors, regenerates all the mocks, and updates the license
check to ignore mockery style mocks.

Change-Id: I7d8ca47254459e2929286cf614e09893b254d35d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Author: Jason Yellick

core/cclifecycle/lifecycle.go

@@ -39,15 +39,15 @@ type LifeCycleChangeListener interface {
 // HandleMetadataUpdate is triggered upon a change in the chaincode lifecycle change
 type HandleMetadataUpdate func(channel string, chaincodes chaincode.MetadataSet)
 
-// go:generate mockery -dir core/cclifecycle -name LifeCycleChangeListener -case underscore  -output core/cclifecycle/mocks/
+//go:generate mockery -dir . -name LifeCycleChangeListener -case underscore  -output mocks/
 
 // LifeCycleChangeListener runs whenever there is a change to the metadata
 // // of a chaincode in the context of a specific channel
 func (mdUpdate HandleMetadataUpdate) LifeCycleChangeListener(channel string, chaincodes chaincode.MetadataSet) {
 	mdUpdate(channel, chaincodes)
 }
 
-// go:generate mockery -dir core/cclifecycle -name Enumerator -case underscore  -output core/cclifecycle/mocks/
+//go:generate mockery -dir . -name Enumerator -case underscore  -output mocks/
 
 // Enumerator enumerates chaincodes
 type Enumerator interface {
@@ -63,7 +63,7 @@ func (listCCs Enumerate) Enumerate() ([]chaincode.InstalledChaincode, error) {
 	return listCCs()
 }
 
-// go:generate mockery -dir core/cclifecycle -name Query -case underscore  -output core/cclifecycle/mocks/
+//go:generate mockery -dir . -name Query -case underscore  -output mocks/
 
 // Query queries the state
 type Query interface {
@@ -74,7 +74,7 @@ type Query interface {
 	Done()
 }
 
-// go:generate mockery -dir core/cclifecycle -name QueryCreator -case underscore  -output core/cclifecycle/mocks/
+//go:generate mockery -dir . -name QueryCreator -case underscore  -output mocks/
 
 // QueryCreator creates queries
 type QueryCreator interface {

core/cclifecycle/mocks/enumerator.go

@@ -30,17 +30,17 @@ func (m MapBasedPluginMapper) PluginFactoryByName(name PluginName) validation.Pl
 	return m[string(name)]
 }
 
-// go:generate mockery -dir core/committer/txvalidator/ -name PluginMapper -case underscore -output core/committer/txvalidator/mocks
-// go:generate mockery -dir core/handlers/validation/api/ -name PluginFactory -case underscore -output core/committer/txvalidator/mocks/
-// go:generate mockery -dir core/handlers/validation/api/ -name Plugin -case underscore -output core/committer/txvalidator/mocks/
+//go:generate mockery -dir . -name PluginMapper -case underscore -output mocks/
+//go:generate mockery -dir ../../handlers/validation/api/ -name PluginFactory -case underscore -output mocks/
+//go:generate mockery -dir ../../handlers/validation/api/ -name Plugin -case underscore -output mocks/
 
 // PluginMapper maps plugin names to their corresponding factory instance.
 // Returns nil if the name isn't associated to any plugin.
 type PluginMapper interface {
 	PluginFactoryByName(name PluginName) validation.PluginFactory
 }
 
-// go:generate mockery -dir core/committer/txvalidator/ -name QueryExecutorCreator -case underscore -output core/committer/txvalidator/mocks
+//go:generate mockery -dir . -name QueryExecutorCreator -case underscore -output mocks/
 
 // QueryExecutorCreator creates new query executors
 type QueryExecutorCreator interface {
@@ -75,8 +75,8 @@ type PluginValidator struct {
 	capabilities Capabilities
 }
 
-// go:generate mockery -dir core/handlers/validation/api/capabilities/ -name Capabilities -case underscore -output core/committer/txvalidator/mocks/
-// go:generate mockery -dir msp/ -name IdentityDeserializer -case underscore -output core/committer/txvalidator/mocks
+//go:generate mockery -dir ../../handlers/validation/api/capabilities/ -name Capabilities -case underscore -output mocks/
+//go:generate mockery -dir ../../../msp/ -name IdentityDeserializer -case underscore -output mocks/
 
 // NewPluginValidator creates a new PluginValidator
 func NewPluginValidator(pm PluginMapper, qec QueryExecutorCreator, deserializer msp.IdentityDeserializer, capabilities Capabilities) *PluginValidator {