[FAB-10501] Log EndorseWithPlugin messages at debug

This CR changes the log level for the messages in the main flow
of EndorseWithPlugin from INFO to DEBUG to remove the unnecessary
noise at the info level. It also fixes a few minor golint issues.

Change-Id: I04eca62c891d05e12210197106d11cfbcb68defc
Signed-off-by: Will Lahti <wtlahti@us.ibm.com>

Author: wlahti

core/endorser/plugin_endorser.go

@@ -21,20 +21,23 @@ import (
 
 //go:generate mockery -dir . -name TransientStoreRetriever -case underscore -output mocks/
 //go:generate mockery -dir ../transientstore/ -name Store -case underscore -output mocks/
+
 // TransientStoreRetriever retrieves transient stores
 type TransientStoreRetriever interface {
 	// StoreForChannel returns the transient store for the given channel
 	StoreForChannel(channel string) transientstore.Store
 }
 
 //go:generate mockery -dir . -name ChannelStateRetriever -case underscore -output mocks/
+
 // ChannelStateRetriever retrieves Channel state
 type ChannelStateRetriever interface {
 	// ChannelState returns a QueryCreator for the given Channel
 	NewQueryCreator(channel string) (QueryCreator, error)
 }
 
 //go:generate mockery -dir . -name PluginMapper -case underscore -output mocks/
+
 // PluginMapper maps plugin names to their corresponding factories
 type PluginMapper interface {
 	PluginFactoryByName(name PluginName) endorsement.PluginFactory
@@ -157,10 +160,10 @@ type PluginEndorser struct {
 
 // EndorseWithPlugin endorses the response with a plugin
 func (pe *PluginEndorser) EndorseWithPlugin(ctx Context) (*pb.ProposalResponse, error) {
-	endorserLogger.Info("Entering endorsement for", ctx)
+	endorserLogger.Debug("Entering endorsement for", ctx)
 
 	if ctx.Response == nil {
-		return nil, errors.New("Response is nil")
+		return nil, errors.New("response is nil")
 	}
 
 	if ctx.Response.Status >= shim.ERRORTHRESHOLD {
@@ -191,7 +194,7 @@ func (pe *PluginEndorser) EndorseWithPlugin(ctx Context) (*pb.ProposalResponse,
 		Payload:     prpBytes,
 		Response:    ctx.Response,
 	}
-	endorserLogger.Info("Exiting", ctx)
+	endorserLogger.Debug("Exiting", ctx)
 	return resp, nil
 }
 

core/endorser/plugin_endorser_test.go

@@ -201,8 +201,7 @@ func TestPluginEndorserErrors(t *testing.T) {
 	t.Run("ResponseIsNil", func(t *testing.T) {
 		resp, err := pluginEndorser.EndorseWithPlugin(endorser.Context{})
 		assert.Nil(t, resp)
-		assert.Contains(t, err.Error(), "Response is nil")
-
+		assert.Contains(t, err.Error(), "response is nil")
 	})
 }